Skip to content

S7 elements #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
May 14, 2025
Merged

S7 elements #16

merged 32 commits into from
May 14, 2025

Conversation

teunbrand
Copy link
Owner

Mirrors tidyverse#6355

teunbrand added 30 commits March 4, 2025 15:19
@teunbrand
add S7 as import
8bd9f31
@teunbrand
custom properties for theme elements
d54e464
@teunbrand
convert theme elements to S7 classes
91302e0
@teunbrand
adapt element definitions
8c199a1
@teunbrand
convert element_grob to S7 generic
202b80d
@teunbrand
replace merge_element by S7
df02b37
@teunbrand
implement $.element for backward compatibility
b038e8f
@teunbrand
Use S7 properties
09eef8d
@teunbrand
fix inherits() issues
62d8db4
@teunbrand
fix misc issues
27cdb73
@teunbrand
Revert "implement $.element for backward compatibility"
3bc0d63 
This reverts commit b038e8f.
@teunbrand
don't rely on element$prop
360c975
@teunbrand
move element properties
68fe80b
@teunbrand
convert margin to S7
8c3471e
@teunbrand
I liked index properties as an idea but apparently they print badly
9f69323
@teunbrand
adapt failing example
e4b870b
@teunbrand
resolve merge conflict
4f8a351 
Merge branch 'main' into S7_elements

# Conflicts:
#	R/geom-.R
#	R/save.R
#	R/theme-elements.R
#	R/theme.R
@teunbrand
backport @
b2f143e
@teunbrand
resolve merge conflict
4fbf5cf 
Merge branch 'main' into S7_elements

# Conflicts:
#	R/geom-label.R
#	R/guide-.R
#	R/margins.R
#	R/theme-elements.R
#	R/theme.R
#	man/is_tests.Rd
#	tests/testthat/test-theme.R
@teunbrand
S7-aware is_theme_element()
98fb83e
@teunbrand
utility for grabbing props
f56a504
@teunbrand
use classic extractors and subassignment
a775635
@teunbrand
fallback for register_theme_elements()
b38f3e5
@teunbrand
contingencies for inherits(x, <S7>) on old R versions
aa14c88
@teunbrand
bump staged deprecations
fcfdc69
@teunbrand
add linejoins
924b8b6
@teunbrand
resolve merge conflict
764a2ce 
Merge branch 'main' into S7_elements

# Conflicts:
#	DESCRIPTION
@teunbrand
Disable ggtext::element_markdown() example
6eb2264
@teunbrand
fix failing tests
7595556
@teunbrand
redocument
5797664
teunbrand added 2 commits May 14, 2025 11:16
@teunbrand
resolve merge conflict
18b9273 
Merge branch 'S7_objects' into S7_elements

# Conflicts:
#	NAMESPACE
#	R/plot-construction.R
#	R/theme.R
#	R/zzz.R
#	man/ggplot_add.Rd
#	tests/testthat/test-theme.R
@teunbrand
fix doc links
4b7a189
@teunbrand teunbrand merged commit 8b285a5 into S7_objects May 14, 2025
@teunbrand teunbrand mentioned this pull request May 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@teunbrand