Reduce size

[ai]

-  Package size: 5.88 KB
+  Package size: 4.39 KB

1. setImmediate forced @babel/plugin-transform-runtime to add unnecessary setImmediate and process polyfills.
2. Rare warning wrapped into process.env.NODE_ENV !== "production"
3. propTypes wrapping by Babel (machines must suffer)

[ai]

@theKashey npx size-limit --why helped me here to find these mistakes with setImmediate

[theKashey]

Actually that stuff with setImmediate was a bit unclear for me. I was not using it, just checking it.

[theKashey]

@ai - size did not changed for me. Still 5.89. Even more - I still could see setImmediate and proccess in "--why".

[ai]

Actually that stuff with setImmediate was a bit unclear for me. I was not using it, just checking it.

It was added by @babel/plugin-transform-runtime because it found setImmediate in source code.

size did not changed for me. Still 5.89. Even more - I still could see setImmediate and proccess in "--why".

Di you run yarn size to rebuild dist?

[theKashey]

Sure. I've even published it already :) https://bundlephobia.com/result?p=react-focus-lock@1.17.2

[ai]

Maybe we have some difference in how BundlePhobia count the result?

Try to check bundle size of a real project after the update.

[ai]

Hm. Seems like I found a reason. npm package contains dist/es2015/util.js, so Babel still adds setImmediate. Try to remove dist/ before making a release.

[ai]

Yeap, there are some problems.

Seems like my Babel hack doesn’t work :(

[ai]

Yeap, setImmediate polyfill was inserted by Webpack webpack/webpack#4695

Do you have an idea how we can ask Webpack to not insert its polyfill for setImmediate?

[ai]

I added issue to webpack webpack/webpack#8280

[ai]

I found solution #48 🎉

[theKashey]

then I will access setImmediate in a more ninja way.

[krasnoperov]

JFYI, webpack inserts polyfills for node.js globals: https://webpack.js.org/configuration/node/
This behaviour can be disabled in webpack.config.js:

{
  /* .. */
  node: {
    setImmediate: false,
  }
}

[ai]

@krasnoperov we can’t ask every user to change webpack config :(.

[krasnoperov]

Sure. I believe that polyfill should be disabled by default.

[theKashey]

Look like we are done for today, and magically stripped a few kb. Now I am thinking to run babel on my node-modules, to strip away all not-yet-removed propTypes.

It would also great to create babel or webpack plugin to replace inlined helpers by babel-runtime among each and every file inside node_modules folder. Should be easy, and very effective.

Next iteration, I recon, would be about react hooks, and they will reduce package size a lot.

@ai 💯
@krasnoperov 👍