Skip to content

Major refactor of code base #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 17, 2019
Merged

Major refactor of code base #29

merged 11 commits into from
Jun 17, 2019

Conversation

NickSeagull
Copy link
Contributor

@NickSeagull NickSeagull commented Jun 17, 2019 •
edited
Loading

I refactored the code base, so contributions are (hopefully) easier now.

Changes

  • Bumped Stack resolver to lts-13.25
  • Removed HLint config file (it was the one from the Relude repo, but we don't use Relude anymore)
  • Started using http-client for working with HTTP requests.
  • Now we create a single HTTP manager instead of spawning it with each request
  • Migrate from an MTL stack to checked exceptions, and work in IO
  • Use ByteString and String for mostly everything.
    Removed some Text, because we were converting back and forth from Text and String and we were losing some time with the conversions.

@NickSeagull NickSeagull merged commit 3373663 into master Jun 17, 2019
@NickSeagull NickSeagull deleted the single-process branch June 17, 2019 16:02
@NickSeagull NickSeagull mentioned this pull request Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NickSeagull