Massively improves performance when not using labels#115
Merged
themustafaomar merged 1 commit intothemustafaomar:mainfrom Feb 22, 2023
Merged
Conversation
Owner
|
Thanks for the great explanation and support! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a map with over 11k regions which loads very slow. In the profiler I found out that the bbox call was the issue. It calls the bbox when creating the region and uses it to place the label in the right position, but we are not using labels at all. This small change improves the loading speed of our maps over 90%.
The reason the getbbox calculation is so slow is because it has to recalculate the style and in many cases causes a reflow of the page. There might be a way to get the bbox without doing the reflow, that would be a good performance improvement for people using labels.