Selection API and bug fix.#162
Merged
themustafaomar merged 4 commits intothemustafaomar:mainfrom Aug 9, 2024
Merged
Conversation
…n't deselected. 2. Add a selectMarkes api method.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Clearing and select regions/markers explicitly as regions is not a private property, ther old way will error out becuase getSelected/clearSelected takes a _ as a prefix
Owner
|
Hi @eswwaa Thanks for brining this into my mind! I've applied some changes:
|
Contributor
Author
|
Thanks for getting this in themustafaomar, jsvectormaps is great. Any idea when a new package will be on npm? |
Owner
|
Maybe by the end of this month. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix single selection problem where previously selected markers aren't deselected.
Fix problem where selected markers aren't retrieved correctly during marker selection.
Add a selectMarkers api method.