Skip to content

fix: Angular too much recursion error (#75)#76

Merged
themustafaomar merged 1 commit intothemustafaomar:masterfrom
smoelker:master
Mar 23, 2022
Merged

fix: Angular too much recursion error (#75)#76
themustafaomar merged 1 commit intothemustafaomar:masterfrom
smoelker:master

Conversation

@smoelker
Copy link
Copy Markdown
Contributor

Fixed the too much recursion error when using the library in Angular.

@themustafaomar themustafaomar merged commit 222af02 into themustafaomar:master Mar 23, 2022
@themustafaomar
Copy link
Copy Markdown
Owner

Thank you!

You've just fixed another two issues at:

// Initialize the map
init(selector) {
const options = this.params
// @TODO: We can get the selector from params `this.params.selector` but unfortunately
// when passing a DOM element to jsVectorMap constructor, the DOM element doesn't get merged
// with defaults during merging the options so we need to get the selector directly from the options.
this.container = getElement(selector)

And https://github.com/themustafaomar/vuevectormap/blob/e74a7b509380ed4f7aaaa38444163e96c96e06f4/src/js/component.js#L33-L40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants