fix(cli): issue with execvpe on Windows #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
execvpe works differently on Windows, see python/cpython#63323 (comment) for more information, tldr: Windows returns control immediately rather than once the executed command has finished.
theskumar
changed the title
|
@wrongontheinternet, thank you. I'll merge this in. I'm not able to test this locally on Windows or on CI. I'm trying to get the CI to work with Windows, so we have more comprehensive tests on Windows, so these don't regress. Some hard test dependencies don't seem to work on Windows, causing a bit refactor of the test-suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execvpe works differently on Windows.
See python/cpython#63323 (comment) for more information, tldr: Windows returns control immediately rather than once the executed command has finished.
This rolls back #523 just for Windows, and resolves issue #536.
Flake8 passes, and pytest breaks because AFAICT the tests are not designed for running on Windows. It resolves the problems I am seeing on Windows 10 & 11 on x64. This is my first contribution, please let me know if there's anything I should investigate further.