[BUG][JSL] SOF doesn't work after S3

[keqiaozhang]

Describe the bug
Perform S3 test first, then do playback or capture, aplay/arecord will stuck there without output and process cannot be killed.
This issue only happens on HDA mode, on I2S mode, sof works well after S3.

To Reproduce

1. do S3 first
   rtcwake -m mem -s 5
2. then run aplay/arecord
   aplay -Dhw:0,1 -f dat -c 2 -vvv /dev/zero

Reproduction Rate
100%

Expected behavior
SOF works well after S3

Environment
Branch jsl-001-drop-stable
Commit: 921fd95
kernel:
Branch:sof-dev
Commit: 0e05b6e

dmesg

[  142.672487] sof-audio-pci 0000:00:1f.3: ipc rx: 0x90020000: GLB_TRACE_MSG
[  142.672515] sof-audio-pci 0000:00:1f.3: ipc rx done: 0x90020000: GLB_TRACE_MSG
[  143.172281] sof-audio-pci 0000:00:1f.3: ipc rx: 0x90020000: GLB_TRACE_MSG
[  143.172312] sof-audio-pci 0000:00:1f.3: ipc rx done: 0x90020000: GLB_TRACE_MSG
[  318.752895] snd_hda_codec_hdmi ehdaudio0D2: Unable to sync register 0x2f8100. -5
[  323.762163] sof-audio-pci 0000:00:1f.3: pcm: open stream 1 dir 0
[  323.762169] sof-audio-pci 0000:00:1f.3: period min 192 max 16384 bytes
[  323.762172] sof-audio-pci 0000:00:1f.3: period count 2 max 16
[  323.762175] sof-audio-pci 0000:00:1f.3: buffer max 65536 bytes
[  323.762910] sof-audio-pci 0000:00:1f.3: pcm: close stream 1 dir 0
[  434.210982] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0x20140000 successful
[  434.245658] sof-audio-pci 0000:00:1f.3: ipc tx: 0x40010000: GLB_PM_MSG: CTX_SAVE
[  434.245835] sof-audio-pci 0000:00:1f.3: ipc tx succeeded: 0x40010000: GLB_PM_MSG: CTX_SAVE
[  434.245912] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0x1010303 successful
[  434.245917] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0x303 successful
[  434.245921] sof-audio-pci 0000:00:1f.3: DSP core(s) enabled? 0 : core_mask 3
[  434.245963] sof-audio-pci 0000:00:1f.3: Debug PCIR: 00000010 at  00000044

dmesg_s3.txt

[plbossart]

@kv2019i does this ring a bell?

[kv2019i]

@plbossart no, this looks like a new case. I wonder if graphics came back ok from S3. Only error in the log before the audio register sync error is this:
[ 130.432125] [drm:intel_gt_verify_workarounds [i915]] ERROR GT workaround lost on init! (9524=0/0, expected 10000, mask=10000)

@keqiaozhang Would be interesting to check when this started happening? Perhaps a recent upstream merge?

[keqiaozhang]

@kv2019i We didn't do a regular test on JSL, because no JSL devices available in PRC now. We will get one next week.
I found this issue on COE's device with remote testing. So not sure if this is a regression.

[kv2019i]

@keqiaozhang I believe this same bug as #1763 (now fixed in sof-dev) and is triggered by difference in BIOS settings for HDA link values versus hw defaults. This happen on JSL/TGL/ICL/GLK platforms and newer.

[plbossart]

@keqiaozhang is this bug still current? it's been going on for ~2 months now.

[keqiaozhang]

@emilchudzik
Could you help to verify this issue with latest sof-dev on your JSL device? Thanks .

[emilchudzik]

Issue exists on my JSL (HDA mode).
kernel: 24d9781/sof-dev
FW: c35e1aa/master

Steps:

• aplay works well before S3
• S3 works
• aplay don't start after S3, it seems like freeze after enter command. Even if I check: "aplay -l" this commant last about 20-30sec to display output.
  In dmesg I see:
  

full dmesg:
dmesg_S3.txt

[kv2019i]

@emilchudzik Does HDMI work before S3 on this platform? The error:

[ 714.317335] snd_hda_codec_hdmi ehdaudio0D2: Unable to sync register 0x2f8100. -5

.. is typically seen when the hardware is something our HDMI codec driver does not identify. We recently added one JSL variant more, but I wonder if there is still more, or there is an issue with your kernel config.

To debug this further, can you also share me output of "cat /proc/asound/card0/codec#2" before S3 is attempted

And also, please share the config file (.config) that was used to compile the kernel.

[emilchudzik]

ok, I will check HDMI.

I just check dmesg and playback that I run yesterday (19h ago made S3) and playback currently keep working:

[emilchudzik]

@kv2019i I haved just check issue again with headphones connected to monitor.
Playback works through HDMI2 after reboot and before entering S3.
After S3 playback doesn't work. Some time later it recover as I describe comments above.

Logs:
proc_asound_card0_codec2.txt

dmesg4_aplay_afterS3.txt

for building kernel I used: kconfig-sof-default.sh
.config: config.txt