SoundWire: cleanup baseline #782
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual inspections confirmed by checkpatch.pl --strict expose a number of style issues, specifically parameter alignment is inconsistent as if different contributors used different styles. Before we restart support for SoundWire with Sound Open Firmware on Intel platforms, let's clean all this. Fix Kconfig help, spelling, SPDX format, alignment, spurious parentheses, bool comparisons to true/false. No new functionality added. Signed-off-by: Pierre-Louis Bossart <[email protected]>
No need for explicit initialization of page and ssp fields, they are already zeroed with a memset. Detected with cppcheck: [drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is reassigned a value before the old one has been used. Signed-off-by: Pierre-Louis Bossart <[email protected]>
no need to reset return value. Detected with cppcheck: [drivers/soundwire/stream.c:332]: (style) Variable 'ret' is assigned a value that is never used. Signed-off-by: Pierre-Louis Bossart <[email protected]>
bardliao
approved these changes
Apr 4, 2019
Collaborator
bardliao
left a comment
bardliao
left a comment
There was a problem hiding this comment.
Thanks @plbossart It looks good to me.
ranj063
reviewed
Apr 4, 2019
ranj063
approved these changes
Apr 4, 2019
Member
Author
|
will submit upstream first, additional changes needed |
|
@plbossart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we start, let's clean this up.
@xiulipan can you please add soundwire-defconfig to the SOF and SST options for the kernel CI? Thanks!