Repository navigation
fix bugs - #11
fix bugs#11abdelkabirouadoukou wants to merge 5 commits into
Conversation
… component fix: improve server functions documentation for clarity chore: update feature descriptions for consistency style: enhance homepage layout and styling for better user experience style: update global styles and animations for improved aesthetics fix: correct package version for @thexjs/env feat: add contact page with form for user inquiries chore: add TypeScript configuration for @thexjs/env package fix: adjust button attributes in settings page for consistency
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 34 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (23)
📝 WalkthroughWalkthroughThe PR removes island-serving paths, simplifies client navigation and CLI output, updates public middleware exports, refreshes landing templates and examples, adds a contact page, and revises documentation, styling, configuration, and package versions. ChangesRuntime and build pipeline
Landing templates and examples
Estimated code review effort: 5 (Critical) | ~120 minutes Sequence Diagram(s)sequenceDiagram
participant Request
participant createApp
participant build
participant Filesystem
Request->>createApp: Render route or request bundle
createApp->>build: Build route island output
build->>Filesystem: Write and read generated bundle
build-->>createApp: Return bundle URL or fallback hydration
createApp-->>Request: Return rendered response
Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Added overrides in biome.json to disable specific linter rules for syntax.tsx. - Updated DashboardPage to include a comment for ignoring linting on dangerouslySetInnerHTML. - Enhanced LoginPage by adding htmlFor attributes to labels for better accessibility. - Modified PlaceholderPage buttons to include type="button" for clarity and prevent unintended form submissions. - Updated BlogPostPage to include a comment for ignoring linting on dangerouslySetInnerHTML with a note on content safety. - Improved HomePage button accessibility by adding type="button". - Enhanced MainLayout and RootLayout SVGs with aria-hidden attributes and added sr-only spans for better screen reader support. - Updated DocsLayout to include comments for ignoring linting on dangerouslySetInnerHTML for static scripts and styles. - Refactored create-thexjs-app template files to include similar accessibility improvements and linting comments as above.
There was a problem hiding this comment.
Actionable comments posted: 13
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/core/src/build.ts (1)
259-294: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick winLog the failure reason when island bundling falls back.
If
Bun.spawnSyncfails, the function silently writesgenerateFallbackHydrationoutput with no diagnostic. Developers get no signal that an island failed to bundle and will only notice at runtime that hydration never occurred. Logresult.stderr(orresult.stdout) on failure so the cause is visible during the build.♻️ Proposed diagnostic logging on bundling failure
if (result.success) { assertNoEnvLeakage(readFileSync(bundlePath, "utf-8"), bundlePath); return [`/_islands/${entryId}/${entryId}.js`]; } + console.warn( + ` [islands] bundling failed for ${routeFilePath}: ${result.stderr?.toString() ?? "unknown error"}`, + ); writeFileSync(bundlePath, generateFallbackHydration(islandNames), "utf-8"); return [`/_islands/${entryId}/${entryId}.js`]; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/core/src/build.ts` around lines 259 - 294, Update the failure branch in bundleRouteIslands after Bun.spawnSync to log the available result.stderr or result.stdout diagnostic before writing generateFallbackHydration output. Preserve the existing fallback file generation and returned bundle URL.
🧹 Nitpick comments (3)
packages/create-thexjs-app/templates/landing/src/layouts/main.tsx (1)
29-43: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDuplicated GitHub SVG icon across the shared header and homepage CTA. The same long
<svg>path data is copied verbatim in two files, so any future icon update requires editing both.
packages/create-thexjs-app/templates/landing/src/layouts/main.tsx#L29-L43: extract the icon into a sharedGithubIconcomponent (or uselucide-react'sGithubicon) and import it here, in the nav link.packages/create-thexjs-app/templates/landing/src/pages/index.tsx#L174-L188: import the same shared icon component in the CTA link instead of inlining the path again.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/create-thexjs-app/templates/landing/src/layouts/main.tsx` around lines 29 - 43, Extract the duplicated GitHub SVG into a shared GithubIcon component, or reuse lucide-react’s Github icon, and import it in packages/create-thexjs-app/templates/landing/src/layouts/main.tsx lines 29-43 for the nav link. Update packages/create-thexjs-app/templates/landing/src/pages/index.tsx lines 174-188 to use the same shared icon instead of inlining the SVG path.packages/create-thexjs-app/templates/landing/src/pages/docs/_layout.tsx (1)
67-114: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winActive-page highlighting was removed from the docs sidebar.
The embedded script no longer matches the current URL against sidebar links and no longer applies an active-state class. Combined with the removed
data-doc-linkattribute, the sidebar can no longer indicate which doc page the reader is currently on.Consider restoring current-page indication (e.g., compare
window.location.pathnameagainst each link'shrefand apply anaria-current="page"attribute plus a visual style) to preserve navigation usability.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/create-thexjs-app/templates/landing/src/pages/docs/_layout.tsx` around lines 67 - 114, Restore active-page highlighting in the docs sidebar by updating the embedded script’s link handling around `SidebarNav` and the sidebar initialization IIFE: compare `window.location.pathname` with each sidebar link’s URL, mark the matching link with `aria-current="page"`, and apply the existing active visual-state class. Ensure the corresponding sidebar links expose the identifier or href needed for matching, while preserving the mobile close behavior.examples/basic/public/styles.css (1)
2-1306: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winExclude generated CSS output from stylelint.
This file is Tailwind CSS v4's generated build output (
@layer theme/base/utilities/properties), not hand-authored CSS. The static analysis findings (missing blank lines before declarations, keyword casing, deprecatedappearance: button) all point at generated Tailwind preflight/utility rules. Editing them by hand does not fix anything, since the next build regenerates this file. Add this path to the stylelint ignore configuration instead, so CI does not report false positives against generated output.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@examples/basic/public/styles.css` around lines 2 - 1306, Exclude the generated Tailwind CSS output represented by styles.css from stylelint through the repository’s stylelint ignore configuration. Do not modify the generated rules; add the file’s existing path or matching ignore pattern to the established ignore mechanism so future builds remain unaffected.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@examples/basic/src/components/Link.tsx`:
- Around line 3-15: Update LinkProps and the Link component to extend or
otherwise accept native anchor attributes while preserving the existing href,
children, className, and prefetch behavior. Destructure only the custom props,
collect the remaining anchor props, and forward them to the underlying <a> so
target, rel, aria attributes, onClick, and other supported native props remain
available.
In `@examples/basic/src/pages/login.tsx`:
- Around line 58-63: Restore explicit label-to-input associations in the login
form: add matching htmlFor values to the Username and Password labels and
corresponding id values to their Input components. Preserve the existing field
names, defaults, and required/password behavior so label clicks focus the
correct inputs.
In `@examples/landing/src/styles/globals.css`:
- Around line 42-69: Add --destructive-foreground and
--sidebar-accent-foreground to the :root token definitions, using appropriate
contrasting foreground values consistent with the existing paired color
variables and the `@theme` inline mappings.
- Around line 80-98: Restore prefers-reduced-motion handling in globals.css for
the infinite float and pulse-glow animations by adding an appropriate media
query that disables or otherwise prevents their continuous animation when
reduced motion is requested. Keep the existing animation behavior unchanged for
users without that preference.
In `@packages/cli/package.json`:
- Line 3: Update the version fields in packages/cli/package.json (line 3),
packages/create-thexjs-app/package.json (line 3),
packages/adapter-vercel/package.json (line 3), and packages/env/package.json
(line 3) to new unreleased version numbers, or revert these manifests to local
unpublished versions; do not retain the currently published versions.
In `@packages/core/package.json`:
- Around line 42-48: Remove the self-referential "`@thexjs/core`": "workspace:*"
entry from the devDependencies in packages/core/package.json. Preserve the
existing react and react-dom development dependencies.
- Line 3: Restore the packages/core package version to the intended unreleased
value, ensuring it is higher than 0.1.5 (such as 0.1.6) rather than retaining
the downgrade to 0.1.3.
In `@packages/core/src/build.ts`:
- Around line 296-307: Update generateHydrateEntry to emit explicit imports for
React and ReactDOM before using React.createElement and ReactDOM.hydrateRoot,
ensuring the generated hydration entry preserves the existing island hydration
behavior and the external dependencies remain available to the bundle.
- Around line 269-270: Normalize routeRel to slash-separated separators before
passing it to generateHydrateEntry, replacing platform-specific backslashes
produced by join with forward slashes for the generated ES module import
specifier. Keep the existing relative-route calculation and islandNames handling
unchanged.
In `@packages/create-thexjs-app/templates/landing/src/pages/contact.tsx`:
- Around line 32-95: Implement a POST handler for the /contact action used by
the contact form in the contact page component. Add the route or server action
that accepts the submitted name, email, subject, and message fields, processes
the submission, and returns an appropriate response while preserving the
existing page route.
In `@packages/create-thexjs-app/templates/landing/src/styles/globals.css`:
- Around line 26-68: Add the missing --destructive-foreground and
--sidebar-accent-foreground declarations to the :root block in globals.css,
assigning each a readable foreground color consistent with the existing
destructive and sidebar-accent theme tokens referenced by `@theme` inline.
- Around line 80-98: Add a prefers-reduced-motion: reduce media query in
globals.css targeting the looping float and pulse-glow animation classes,
including animate-float and animate-pulse-glow, and disable or substantially
shorten their animations while preserving normal behavior otherwise.
In `@scripts/convert-code-blocks.mjs`:
- Around line 42-44: Update the generated CodeBlock command in the conversion
output to use the published scaffold template: replace the bun create target
with thexjs-app@latest while preserving the my-app argument and subsequent
commands.
---
Outside diff comments:
In `@packages/core/src/build.ts`:
- Around line 259-294: Update the failure branch in bundleRouteIslands after
Bun.spawnSync to log the available result.stderr or result.stdout diagnostic
before writing generateFallbackHydration output. Preserve the existing fallback
file generation and returned bundle URL.
---
Nitpick comments:
In `@examples/basic/public/styles.css`:
- Around line 2-1306: Exclude the generated Tailwind CSS output represented by
styles.css from stylelint through the repository’s stylelint ignore
configuration. Do not modify the generated rules; add the file’s existing path
or matching ignore pattern to the established ignore mechanism so future builds
remain unaffected.
In `@packages/create-thexjs-app/templates/landing/src/layouts/main.tsx`:
- Around line 29-43: Extract the duplicated GitHub SVG into a shared GithubIcon
component, or reuse lucide-react’s Github icon, and import it in
packages/create-thexjs-app/templates/landing/src/layouts/main.tsx lines 29-43
for the nav link. Update
packages/create-thexjs-app/templates/landing/src/pages/index.tsx lines 174-188
to use the same shared icon instead of inlining the SVG path.
In `@packages/create-thexjs-app/templates/landing/src/pages/docs/_layout.tsx`:
- Around line 67-114: Restore active-page highlighting in the docs sidebar by
updating the embedded script’s link handling around `SidebarNav` and the sidebar
initialization IIFE: compare `window.location.pathname` with each sidebar link’s
URL, mark the matching link with `aria-current="page"`, and apply the existing
active visual-state class. Ensure the corresponding sidebar links expose the
identifier or href needed for matching, while preserving the mobile close
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1f33e5d4-4f90-4a83-96f0-cd2eca673015
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (52)
TASKS.mdbiome.jsonexamples/basic/package.jsonexamples/basic/public/styles.cssexamples/basic/src/components/Link.tsxexamples/basic/src/pages/login.tsxexamples/basic/src/pages/placeholder.tsxexamples/blog/src/pages/index.tsxexamples/default/src/layouts/main.tsxexamples/landing/src/components/code-block.tsxexamples/landing/src/layouts/main.tsxexamples/landing/src/pages/docs/_layout.tsxexamples/landing/src/pages/docs/installation.tsxexamples/landing/src/pages/docs/server-functions.tsxexamples/landing/src/pages/features.tsxexamples/landing/src/pages/index.tsxexamples/landing/src/styles/globals.cssexamples/saas/src/pages/dashboard/settings.tsxpackages/adapter-vercel/package.jsonpackages/cli/package.jsonpackages/cli/src/index.tspackages/cli/src/terminal.tspackages/core/package.jsonpackages/core/src/build.test.tspackages/core/src/build.tspackages/core/src/client-nav.tspackages/core/src/createApp.tspackages/core/src/index.tspackages/core/src/island-bundle.tspackages/core/src/link.test.tspackages/core/src/link.tsxpackages/core/src/live-reload.tspackages/core/src/security/env-isolation.tspackages/core/src/security/headers.tspackages/create-thexjs-app/package.jsonpackages/create-thexjs-app/src/index.tspackages/create-thexjs-app/src/terminal.tspackages/create-thexjs-app/templates/basic/src/components/Link.tsxpackages/create-thexjs-app/templates/landing/src/components/code-block.tsxpackages/create-thexjs-app/templates/landing/src/layouts/main.tsxpackages/create-thexjs-app/templates/landing/src/pages/contact.tsxpackages/create-thexjs-app/templates/landing/src/pages/docs/_layout.tsxpackages/create-thexjs-app/templates/landing/src/pages/docs/installation.tsxpackages/create-thexjs-app/templates/landing/src/pages/docs/server-functions.tsxpackages/create-thexjs-app/templates/landing/src/pages/features.tsxpackages/create-thexjs-app/templates/landing/src/pages/index.tsxpackages/create-thexjs-app/templates/landing/src/styles/globals.csspackages/create-thexjs-app/templates/landing/tsconfig.jsonpackages/create-thexjs-app/templates/saas/src/pages/dashboard/settings.tsxpackages/env/package.jsonpackages/env/tsconfig.jsonscripts/convert-code-blocks.mjs
💤 Files with no reviewable changes (7)
- packages/core/src/link.tsx
- packages/core/src/link.test.ts
- packages/core/src/index.ts
- packages/core/src/island-bundle.ts
- packages/create-thexjs-app/src/terminal.ts
- packages/cli/src/terminal.ts
- TASKS.md
| interface LinkProps { | ||
| href: string; | ||
| children: ReactNode; | ||
| className?: string; | ||
| prefetch?: boolean; | ||
| } | ||
|
|
||
| export type { LinkProps }; | ||
| export default function Link({ href, children, className, prefetch = true }: LinkProps) { | ||
| return ( | ||
| <a href={href} className={className} data-no-nav={prefetch ? undefined : ""}> | ||
| {children} | ||
| </a> | ||
| ); |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
ast-grep outline examples/basic/src --items all --type function
rg -n -C 4 --glob '*.{ts,tsx}' 'components/Link|<Link\b' examples/basic/srcRepository: abdelkabirouadoukou/x
Length of output: 2974
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Link.tsx =="
cat -n examples/basic/src/components/Link.tsx
echo
echo "== Link usages in examples/basic/src =="
rg -n -C 3 --glob '*.{ts,tsx}' '^\s*<Link\b|components/Link|from ["'\'']\.\./components/Link["'\'']' examples/basic/src || true
echo
echo "== LinkProps definitions/import references =="
rg -n --glob '*.{ts,tsx}' 'interface LinkProps|type LinkProps|LinkProps|`@thexjs/core`' examples/basic/srcRepository: abdelkabirouadoukou/x
Length of output: 3022
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Locate `@thexjs/core` package references =="
rg -n --glob 'package.json' '"`@thexjs/core`"|`@thexjs/core`' .
echo
echo "== Link component import references in repository =="
rg -n --glob '*.{ts,tsx}' 'components/Link|"\.\./components/Link"|from ["'\'']\.\./components/Link["'\'']' .Repository: abdelkabirouadoukou/x
Length of output: 1036
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== local Link.tsx =="
cat -n packages/core/src/components/Link.tsx
echo
echo "== templates src link usages =="
rg -n -C 3 --glob '*.{ts,tsx}' '<Link\b|components/Link|from ["'\'']`@thexjs/core`["'\'']' packages/create-thexjs-app/templatesRepository: abdelkabirouadoukou/x
Length of output: 250
Accept and render native anchor props on Link.
The narrowed LinkProps blocks props such as target, rel, aria-*, and onClick that a core @thexjs/core Link normally supports. Keep those native anchor props in the component API and forward matching anchor props to the underlying <a>.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@examples/basic/src/components/Link.tsx` around lines 3 - 15, Update LinkProps
and the Link component to extend or otherwise accept native anchor attributes
while preserving the existing href, children, className, and prefetch behavior.
Destructure only the custom props, collect the remaining anchor props, and
forward them to the underlying <a> so target, rel, aria attributes, onClick, and
other supported native props remain available.
| :root { | ||
| --radius: 0.625rem; | ||
| --background: #060910; | ||
| --foreground: #e4eaf4; | ||
| --card: #0c1018; | ||
| --card-foreground: #e4eaf4; | ||
| --popover: #0c1018; | ||
| --popover-foreground: #e4eaf4; | ||
| --radius: 0.75rem; | ||
| --background: oklch(0.11 0.015 265); | ||
| --foreground: oklch(0.96 0.01 265); | ||
| --card: oklch(0.16 0.02 265); | ||
| --card-foreground: oklch(0.96 0.01 265); | ||
| --popover: oklch(0.16 0.02 265); | ||
| --popover-foreground: oklch(0.96 0.01 265); | ||
| --primary: oklch(0.72 0.18 35); | ||
| --primary-foreground: #0a0d14; | ||
| --secondary: #3dd6c6; | ||
| --secondary-foreground: #060910; | ||
| --muted: #121824; | ||
| --muted-foreground: #7b879c; | ||
| --accent: #e8952f; | ||
| --accent-foreground: #0a0d14; | ||
| --destructive: #f07178; | ||
| --border: #1a2233; | ||
| --input: #1a2233; | ||
| --ring: #e8952f; | ||
| --terminal-bg: #05080f; | ||
| --terminal-bar: #0a0f18; | ||
| --terminal-border: #1c2638; | ||
| --terminal-text: #d8e1f0; | ||
| --terminal-muted: #6b7f9a; | ||
| --terminal-prompt: #e8952f; | ||
| --terminal-label: #5a6d88; | ||
| --terminal-glow: 0 24px 80px -20px rgba(232, 149, 47, 0.12); | ||
| --primary-foreground: oklch(0.11 0.015 265); | ||
| --secondary: oklch(0.65 0.15 195); | ||
| --secondary-foreground: oklch(0.96 0.01 265); | ||
| --muted: oklch(0.2 0.015 265); | ||
| --muted-foreground: oklch(0.58 0.02 265); | ||
| --accent: oklch(0.72 0.18 35); | ||
| --accent-foreground: oklch(0.11 0.015 265); | ||
| --destructive: oklch(0.63 0.2 30); | ||
| --border: oklch(0.22 0.015 265); | ||
| --input: oklch(0.22 0.015 265); | ||
| --ring: oklch(0.72 0.18 35); | ||
| --sidebar: oklch(0.16 0.02 265); | ||
| --sidebar-foreground: oklch(0.96 0.01 265); | ||
| --sidebar-primary: oklch(0.72 0.18 35); | ||
| --sidebar-primary-foreground: oklch(0.11 0.015 265); | ||
| --sidebar-accent: oklch(0.2 0.015 265); | ||
| --sidebar-border: oklch(0.22 0.015 265); | ||
| --sidebar-ring: oklch(0.72 0.18 35); | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Add missing --destructive-foreground and --sidebar-accent-foreground definitions.
The @theme inline block maps --color-destructive-foreground to var(--destructive-foreground) (Line 26) and --color-sidebar-accent-foreground to var(--sidebar-accent-foreground) (Line 35), but neither --destructive-foreground nor --sidebar-accent-foreground is defined in this :root block. Every other paired token (primary, secondary, muted, accent, card, popover, sidebar, sidebar-primary) has a matching -foreground value; these two do not.
An undefined custom property with no fallback resolves to an invalid value (treated as unset), so any element using text-destructive-foreground or text-sidebar-accent-foreground loses its intended contrast color instead of rendering the designed foreground color.
🎨 Proposed fix to add the missing tokens
--destructive: oklch(0.63 0.2 30);
+ --destructive-foreground: oklch(0.96 0.01 265);
--border: oklch(0.22 0.015 265); --sidebar-accent: oklch(0.2 0.015 265);
+ --sidebar-accent-foreground: oklch(0.96 0.01 265);
--sidebar-border: oklch(0.22 0.015 265);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| :root { | |
| --radius: 0.625rem; | |
| --background: #060910; | |
| --foreground: #e4eaf4; | |
| --card: #0c1018; | |
| --card-foreground: #e4eaf4; | |
| --popover: #0c1018; | |
| --popover-foreground: #e4eaf4; | |
| --radius: 0.75rem; | |
| --background: oklch(0.11 0.015 265); | |
| --foreground: oklch(0.96 0.01 265); | |
| --card: oklch(0.16 0.02 265); | |
| --card-foreground: oklch(0.96 0.01 265); | |
| --popover: oklch(0.16 0.02 265); | |
| --popover-foreground: oklch(0.96 0.01 265); | |
| --primary: oklch(0.72 0.18 35); | |
| --primary-foreground: #0a0d14; | |
| --secondary: #3dd6c6; | |
| --secondary-foreground: #060910; | |
| --muted: #121824; | |
| --muted-foreground: #7b879c; | |
| --accent: #e8952f; | |
| --accent-foreground: #0a0d14; | |
| --destructive: #f07178; | |
| --border: #1a2233; | |
| --input: #1a2233; | |
| --ring: #e8952f; | |
| --terminal-bg: #05080f; | |
| --terminal-bar: #0a0f18; | |
| --terminal-border: #1c2638; | |
| --terminal-text: #d8e1f0; | |
| --terminal-muted: #6b7f9a; | |
| --terminal-prompt: #e8952f; | |
| --terminal-label: #5a6d88; | |
| --terminal-glow: 0 24px 80px -20px rgba(232, 149, 47, 0.12); | |
| --primary-foreground: oklch(0.11 0.015 265); | |
| --secondary: oklch(0.65 0.15 195); | |
| --secondary-foreground: oklch(0.96 0.01 265); | |
| --muted: oklch(0.2 0.015 265); | |
| --muted-foreground: oklch(0.58 0.02 265); | |
| --accent: oklch(0.72 0.18 35); | |
| --accent-foreground: oklch(0.11 0.015 265); | |
| --destructive: oklch(0.63 0.2 30); | |
| --border: oklch(0.22 0.015 265); | |
| --input: oklch(0.22 0.015 265); | |
| --ring: oklch(0.72 0.18 35); | |
| --sidebar: oklch(0.16 0.02 265); | |
| --sidebar-foreground: oklch(0.96 0.01 265); | |
| --sidebar-primary: oklch(0.72 0.18 35); | |
| --sidebar-primary-foreground: oklch(0.11 0.015 265); | |
| --sidebar-accent: oklch(0.2 0.015 265); | |
| --sidebar-border: oklch(0.22 0.015 265); | |
| --sidebar-ring: oklch(0.72 0.18 35); | |
| } | |
| :root { | |
| --radius: 0.75rem; | |
| --background: oklch(0.11 0.015 265); | |
| --foreground: oklch(0.96 0.01 265); | |
| --card: oklch(0.16 0.02 265); | |
| --card-foreground: oklch(0.96 0.01 265); | |
| --popover: oklch(0.16 0.02 265); | |
| --popover-foreground: oklch(0.96 0.01 265); | |
| --primary: oklch(0.72 0.18 35); | |
| --primary-foreground: oklch(0.11 0.015 265); | |
| --secondary: oklch(0.65 0.15 195); | |
| --secondary-foreground: oklch(0.96 0.01 265); | |
| --muted: oklch(0.2 0.015 265); | |
| --muted-foreground: oklch(0.58 0.02 265); | |
| --accent: oklch(0.72 0.18 35); | |
| --accent-foreground: oklch(0.11 0.015 265); | |
| --destructive: oklch(0.63 0.2 30); | |
| --destructive-foreground: oklch(0.96 0.01 265); | |
| --border: oklch(0.22 0.015 265); | |
| --input: oklch(0.22 0.015 265); | |
| --ring: oklch(0.72 0.18 35); | |
| --sidebar: oklch(0.16 0.02 265); | |
| --sidebar-foreground: oklch(0.96 0.01 265); | |
| --sidebar-primary: oklch(0.72 0.18 35); | |
| --sidebar-primary-foreground: oklch(0.11 0.015 265); | |
| --sidebar-accent: oklch(0.2 0.015 265); | |
| --sidebar-accent-foreground: oklch(0.96 0.01 265); | |
| --sidebar-border: oklch(0.22 0.015 265); | |
| --sidebar-ring: oklch(0.72 0.18 35); | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@examples/landing/src/styles/globals.css` around lines 42 - 69, Add
--destructive-foreground and --sidebar-accent-foreground to the :root token
definitions, using appropriate contrasting foreground values consistent with the
existing paired color variables and the `@theme` inline mappings.
| @keyframes float { | ||
| 0%, | ||
| 100% { | ||
| transform: translateY(0); | ||
| transform: translateY(0px); | ||
| } | ||
| 50% { | ||
| transform: translateY(-8px); | ||
| transform: translateY(-10px); | ||
| } | ||
| } | ||
|
|
||
| @keyframes pulse-glow { | ||
| 0%, | ||
| 100% { | ||
| opacity: 0.45; | ||
| transform: scale(0.98); | ||
| opacity: 0.6; | ||
| filter: blur(40px); | ||
| } | ||
| 50% { | ||
| opacity: 0.85; | ||
| transform: scale(1); | ||
| } | ||
| } | ||
|
|
||
| @keyframes cursor-blink { | ||
| 0%, | ||
| 100% { | ||
| opacity: 1; | ||
| } | ||
| 50% { | ||
| opacity: 0; | ||
| } | ||
| } | ||
|
|
||
| @media (prefers-reduced-motion: reduce) { | ||
| .animate-pulse-glow, | ||
| .animate-cursor { | ||
| animation: none !important; | ||
| filter: blur(60px); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Restore reduced-motion handling for the infinite animations.
float and pulse-glow both run infinite (Lines 38-39) and no longer have a prefers-reduced-motion accommodation, per the removal noted for this range. Users with a reduced-motion preference now get continuous transform and blur animation regardless of their setting.
♿ Proposed fix to respect reduced-motion preference
+@media (prefers-reduced-motion: reduce) {
+ .animate-float,
+ .animate-pulse-glow {
+ animation: none;
+ }
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| @keyframes float { | |
| 0%, | |
| 100% { | |
| transform: translateY(0); | |
| transform: translateY(0px); | |
| } | |
| 50% { | |
| transform: translateY(-8px); | |
| transform: translateY(-10px); | |
| } | |
| } | |
| @keyframes pulse-glow { | |
| 0%, | |
| 100% { | |
| opacity: 0.45; | |
| transform: scale(0.98); | |
| opacity: 0.6; | |
| filter: blur(40px); | |
| } | |
| 50% { | |
| opacity: 0.85; | |
| transform: scale(1); | |
| } | |
| } | |
| @keyframes cursor-blink { | |
| 0%, | |
| 100% { | |
| opacity: 1; | |
| } | |
| 50% { | |
| opacity: 0; | |
| } | |
| } | |
| @media (prefers-reduced-motion: reduce) { | |
| .animate-pulse-glow, | |
| .animate-cursor { | |
| animation: none !important; | |
| filter: blur(60px); | |
| `@keyframes` float { | |
| 0%, | |
| 100% { | |
| transform: translateY(0px); | |
| } | |
| 50% { | |
| transform: translateY(-10px); | |
| } | |
| } | |
| `@keyframes` pulse-glow { | |
| 0%, | |
| 100% { | |
| opacity: 0.6; | |
| filter: blur(40px); | |
| } | |
| 50% { | |
| opacity: 1; | |
| filter: blur(60px); | |
| } | |
| } | |
| `@media` (prefers-reduced-motion: reduce) { | |
| .animate-float, | |
| .animate-pulse-glow { | |
| animation: none; | |
| } | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@examples/landing/src/styles/globals.css` around lines 80 - 98, Restore
prefers-reduced-motion handling in globals.css for the infinite float and
pulse-glow animations by adding an appropriate media query that disables or
otherwise prevents their continuous animation when reduced motion is requested.
Keep the existing animation behavior unchanged for users without that
preference.
| { | ||
| "name": "@thexjs/cli", | ||
| "version": "0.1.6", | ||
| "version": "0.1.5", |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
for manifest in \
packages/cli/package.json \
packages/create-thexjs-app/package.json \
packages/adapter-vercel/package.json \
packages/env/package.json
do
name="$(jq -r '.name' "$manifest")"
version="$(jq -r '.version' "$manifest")"
encoded="$(printf '%s' "$name" | sed 's/@/%40/g; s#/#%2F#g')"
printf '%s@%s: ' "$name" "$version"
if curl -fsSL "https://registry.npmjs.org/${encoded}/${version}" >/dev/null; then
echo "already published"
else
echo "not found in npm registry"
fi
doneRepository: abdelkabirouadoukou/x
Length of output: 381
Do not publish the existing package versions.
The target versions are public in the npm registry and cannot be republished.
packages/cli/package.json: "0.1.5"packages/create-thexjs-app/package.json: "0.1.2"packages/adapter-vercel/package.json: "0.1.1"packages/env/package.json: "0.1.2"
Use new unreleased version numbers unless these rollback manifests to local unpublished state.
📍 Affects 4 files
packages/cli/package.json#L3-L3(this comment)packages/create-thexjs-app/package.json#L3-L3packages/adapter-vercel/package.json#L3-L3packages/env/package.json#L3-L3
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/cli/package.json` at line 3, Update the version fields in
packages/cli/package.json (line 3), packages/create-thexjs-app/package.json
(line 3), packages/adapter-vercel/package.json (line 3), and
packages/env/package.json (line 3) to new unreleased version numbers, or revert
these manifests to local unpublished versions; do not retain the currently
published versions.
| function generateHydrateEntry(routeRelPath: string, islandNames: string[]): string { | ||
| return `import * as Route from "${routeRelPath}"; | ||
|
|
||
| document.querySelectorAll("[data-island]").forEach((el) => { | ||
| const name = el.getAttribute("data-island"); | ||
| if (!name) return; | ||
| const Component = Route.islands?.[name]; | ||
| if (!Component) return; | ||
| const root = ReactDOM.hydrateRoot(el, React.createElement(Component)); | ||
| }); | ||
| `; | ||
| } |
There was a problem hiding this comment.
🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win
Fix missing React/ReactDOM imports in the generated hydration entry.
generateHydrateEntry emits ReactDOM.hydrateRoot(...) and React.createElement(...) but never imports react or react-dom. --external react --external react-dom in the bun build invocation only preserves import statements that already exist; it does not inject them. Since this generated file has no such import statements, React and ReactDOM are undefined globals in the bundled browser script, and hydration throws a ReferenceError for every island on every successful build.
🐛 Proposed fix to import React and ReactDOM in the generated entry
function generateHydrateEntry(routeRelPath: string, islandNames: string[]): string {
- return `import * as Route from "${routeRelPath}";
+ return `import * as React from "react";
+import * as ReactDOM from "react-dom/client";
+import * as Route from "${routeRelPath}";
document.querySelectorAll("[data-island]").forEach((el) => {
const name = el.getAttribute("data-island");
if (!name) return;
const Component = Route.islands?.[name];
if (!Component) return;
const root = ReactDOM.hydrateRoot(el, React.createElement(Component));
});
`;
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| function generateHydrateEntry(routeRelPath: string, islandNames: string[]): string { | |
| return `import * as Route from "${routeRelPath}"; | |
| document.querySelectorAll("[data-island]").forEach((el) => { | |
| const name = el.getAttribute("data-island"); | |
| if (!name) return; | |
| const Component = Route.islands?.[name]; | |
| if (!Component) return; | |
| const root = ReactDOM.hydrateRoot(el, React.createElement(Component)); | |
| }); | |
| `; | |
| } | |
| function generateHydrateEntry(routeRelPath: string, islandNames: string[]): string { | |
| return `import * as React from "react"; | |
| import * as ReactDOM from "react-dom/client"; | |
| import * as Route from "${routeRelPath}"; | |
| document.querySelectorAll("[data-island]").forEach((el) => { | |
| const name = el.getAttribute("data-island"); | |
| if (!name) return; | |
| const Component = Route.islands?.[name]; | |
| if (!Component) return; | |
| const root = ReactDOM.hydrateRoot(el, React.createElement(Component)); | |
| }); | |
| `; | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/core/src/build.ts` around lines 296 - 307, Update
generateHydrateEntry to emit explicit imports for React and ReactDOM before
using React.createElement and ReactDOM.hydrateRoot, ensuring the generated
hydration entry preserves the existing island hydration behavior and the
external dependencies remain available to the bundle.
| <form className="space-y-5 sm:col-span-3" method="POST" action="/contact"> | ||
| <div className="grid gap-5 sm:grid-cols-2"> | ||
| <div> | ||
| <label htmlFor="name" className="block text-sm font-medium mb-2"> | ||
| Name | ||
| </label> | ||
| <input | ||
| id="name" | ||
| name="name" | ||
| required | ||
| className="w-full rounded-xl border border-input bg-card px-4 py-2.5 text-sm text-foreground placeholder:text-muted-foreground focus:outline-none focus:ring-2 focus:ring-ring" | ||
| placeholder="Your name" | ||
| /> | ||
| </div> | ||
| <div> | ||
| <label htmlFor="email" className="block text-sm font-medium mb-2"> | ||
| </label> | ||
| <input | ||
| id="email" | ||
| name="email" | ||
| type="email" | ||
| required | ||
| className="w-full rounded-xl border border-input bg-card px-4 py-2.5 text-sm text-foreground placeholder:text-muted-foreground focus:outline-none focus:ring-2 focus:ring-ring" | ||
| placeholder="you@example.com" | ||
| /> | ||
| </div> | ||
| </div> | ||
| <div> | ||
| <label htmlFor="subject" className="block text-sm font-medium mb-2"> | ||
| Subject | ||
| </label> | ||
| <input | ||
| id="subject" | ||
| name="subject" | ||
| required | ||
| className="w-full rounded-xl border border-input bg-card px-4 py-2.5 text-sm text-foreground placeholder:text-muted-foreground focus:outline-none focus:ring-2 focus:ring-ring" | ||
| placeholder="How can we help?" | ||
| /> | ||
| </div> | ||
| <div> | ||
| <label htmlFor="message" className="block text-sm font-medium mb-2"> | ||
| Message | ||
| </label> | ||
| <textarea | ||
| id="message" | ||
| name="message" | ||
| rows={5} | ||
| required | ||
| className="w-full resize-none rounded-xl border border-input bg-card px-4 py-2.5 text-sm text-foreground placeholder:text-muted-foreground focus:outline-none focus:ring-2 focus:ring-ring" | ||
| placeholder="Tell us more..." | ||
| /> | ||
| </div> | ||
| <button | ||
| type="submit" | ||
| className="inline-flex h-11 items-center gap-2 rounded-xl bg-primary px-6 text-sm font-semibold text-primary-foreground shadow-lg shadow-primary/25 transition-all hover:bg-primary/90" | ||
| > | ||
| Send message <Send className="h-4 w-4" /> | ||
| </button> | ||
| </form> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Search for a route/action handling POST /contact.
rg -n "contact" --glob '*.ts*' -C3 packages/create-thexjs-app/templates/landing examples/landing 2>/dev/null
fd -i contact packages/create-thexjs-app/templates/landing examples/landingRepository: abdelkabirouadoukou/x
Length of output: 4437
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== files under packages/create-thexjs-app/templates/landing/src =="
fd . packages/create-thexjs-app/templates/landing/src -t f | sed 's#^\./##' | sort
echo
echo "== candidate route/action files =="
fd -i '\.(ts|tsx)$' packages/create-thexjs-app/templates/landing/src | grep -E '(/api/|/actions/|/pages/contact\.tsx|package\.json|pnpm-lock\.yaml|next\.config\.)|api|action|route' | sort | sed -n '1,200p'
echo
echo "== contact action/route candidates =="
fd -i '^contact|contact' packages/create-thexjs-app/templates/landing/src | sort
echo
echo "== POST handlers in landing template =="
rg -n "export const POST|POST:|ApiHandler|ServerFunction|serverFunction|action:" packages/create-thexjs-app/templates/landing/src -g '*.ts' -g '*.tsx' || true
echo
echo "== package files =="
fd -i 'pnpm-lock\.yaml|package\.json|next\.config\.(js|mjs|ts)$' packages/create-thexjs-app/templates/landing | sort | while read -r f; do
echo "--- $f"
sed -n '1,220p' "$f"
doneRepository: abdelkabirouadoukou/x
Length of output: 4065
Add a /contact POST handler.
This form posts to /contact, but the template only defines the contact page route. Submitting it will not call a real endpoint; create an API route or server action for /contact.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/create-thexjs-app/templates/landing/src/pages/contact.tsx` around
lines 32 - 95, Implement a POST handler for the /contact action used by the
contact form in the contact page component. Add the route or server action that
accepts the submitted name, email, subject, and message fields, processes the
submission, and returns an appropriate response while preserving the existing
page route.
| --color-destructive-foreground: var(--destructive-foreground); | ||
| --color-border: var(--border); | ||
| --color-input: var(--input); | ||
| --color-ring: var(--ring); | ||
| --color-sidebar: var(--sidebar); | ||
| --color-sidebar-foreground: var(--sidebar-foreground); | ||
| --color-sidebar-primary: var(--sidebar-primary); | ||
| --color-sidebar-primary-foreground: var(--sidebar-primary-foreground); | ||
| --color-sidebar-accent: var(--sidebar-accent); | ||
| --color-sidebar-accent-foreground: var(--sidebar-accent-foreground); | ||
| --color-sidebar-border: var(--sidebar-border); | ||
| --color-sidebar-ring: var(--sidebar-ring); | ||
| --animate-float: float 3s ease-in-out infinite; | ||
| --animate-pulse-glow: pulse-glow 2.8s ease-in-out infinite; | ||
| --animate-cursor: cursor-blink 1.1s step-end infinite; | ||
| --animate-pulse-glow: pulse-glow 2s ease-in-out infinite; | ||
| } | ||
|
|
||
| :root { | ||
| --radius: 0.625rem; | ||
| --background: #060910; | ||
| --foreground: #e4eaf4; | ||
| --card: #0c1018; | ||
| --card-foreground: #e4eaf4; | ||
| --popover: #0c1018; | ||
| --popover-foreground: #e4eaf4; | ||
| --primary: #e8952f; | ||
| --primary-foreground: #0a0d14; | ||
| --secondary: #3dd6c6; | ||
| --secondary-foreground: #060910; | ||
| --muted: #121824; | ||
| --muted-foreground: #7b879c; | ||
| --accent: #e8952f; | ||
| --accent-foreground: #0a0d14; | ||
| --destructive: #f07178; | ||
| --border: #1a2233; | ||
| --input: #1a2233; | ||
| --ring: #e8952f; | ||
| --terminal-bg: #05080f; | ||
| --terminal-bar: #0a0f18; | ||
| --terminal-border: #1c2638; | ||
| --terminal-text: #d8e1f0; | ||
| --terminal-muted: #6b7f9a; | ||
| --terminal-prompt: #e8952f; | ||
| --terminal-label: #5a6d88; | ||
| --terminal-glow: 0 24px 80px -20px rgba(232, 149, 47, 0.12); | ||
| --radius: 0.75rem; | ||
| --background: oklch(0.11 0.015 265); | ||
| --foreground: oklch(0.96 0.01 265); | ||
| --card: oklch(0.16 0.02 265); | ||
| --card-foreground: oklch(0.96 0.01 265); | ||
| --popover: oklch(0.16 0.02 265); | ||
| --popover-foreground: oklch(0.96 0.01 265); | ||
| --primary: oklch(0.72 0.18 35); | ||
| --primary-foreground: oklch(0.11 0.015 265); | ||
| --secondary: oklch(0.65 0.15 195); | ||
| --secondary-foreground: oklch(0.96 0.01 265); | ||
| --muted: oklch(0.2 0.015 265); | ||
| --muted-foreground: oklch(0.58 0.02 265); | ||
| --accent: oklch(0.72 0.18 35); | ||
| --accent-foreground: oklch(0.11 0.015 265); | ||
| --destructive: oklch(0.63 0.2 30); | ||
| --border: oklch(0.22 0.015 265); | ||
| --input: oklch(0.22 0.015 265); | ||
| --ring: oklch(0.72 0.18 35); | ||
| --sidebar: oklch(0.16 0.02 265); | ||
| --sidebar-foreground: oklch(0.96 0.01 265); | ||
| --sidebar-primary: oklch(0.72 0.18 35); | ||
| --sidebar-primary-foreground: oklch(0.11 0.015 265); | ||
| --sidebar-accent: oklch(0.2 0.015 265); | ||
| --sidebar-border: oklch(0.22 0.015 265); | ||
| --sidebar-ring: oklch(0.72 0.18 35); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Add the missing --destructive-foreground and --sidebar-accent-foreground variables.
The @theme inline block references var(--destructive-foreground) (line 26) and var(--sidebar-accent-foreground) (line 35), but neither is defined in the :root block below. --destructive (line 58) and --sidebar-accent (line 66) lack matching foreground counterparts. Any utility built on these theme tokens (text-destructive-foreground, bg-sidebar-accent-foreground, etc.) resolves to an invalid/transparent color instead of a readable foreground color.
Add the missing declarations to :root.
🎨 Proposed fix
--destructive: oklch(0.63 0.2 30);
+ --destructive-foreground: oklch(0.96 0.01 265);
--border: oklch(0.22 0.015 265);
--input: oklch(0.22 0.015 265);
--ring: oklch(0.72 0.18 35);
--sidebar: oklch(0.16 0.02 265);
--sidebar-foreground: oklch(0.96 0.01 265);
--sidebar-primary: oklch(0.72 0.18 35);
--sidebar-primary-foreground: oklch(0.11 0.015 265);
--sidebar-accent: oklch(0.2 0.015 265);
+ --sidebar-accent-foreground: oklch(0.96 0.01 265);
--sidebar-border: oklch(0.22 0.015 265);
--sidebar-ring: oklch(0.72 0.18 35);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| --color-destructive-foreground: var(--destructive-foreground); | |
| --color-border: var(--border); | |
| --color-input: var(--input); | |
| --color-ring: var(--ring); | |
| --color-sidebar: var(--sidebar); | |
| --color-sidebar-foreground: var(--sidebar-foreground); | |
| --color-sidebar-primary: var(--sidebar-primary); | |
| --color-sidebar-primary-foreground: var(--sidebar-primary-foreground); | |
| --color-sidebar-accent: var(--sidebar-accent); | |
| --color-sidebar-accent-foreground: var(--sidebar-accent-foreground); | |
| --color-sidebar-border: var(--sidebar-border); | |
| --color-sidebar-ring: var(--sidebar-ring); | |
| --animate-float: float 3s ease-in-out infinite; | |
| --animate-pulse-glow: pulse-glow 2.8s ease-in-out infinite; | |
| --animate-cursor: cursor-blink 1.1s step-end infinite; | |
| --animate-pulse-glow: pulse-glow 2s ease-in-out infinite; | |
| } | |
| :root { | |
| --radius: 0.625rem; | |
| --background: #060910; | |
| --foreground: #e4eaf4; | |
| --card: #0c1018; | |
| --card-foreground: #e4eaf4; | |
| --popover: #0c1018; | |
| --popover-foreground: #e4eaf4; | |
| --primary: #e8952f; | |
| --primary-foreground: #0a0d14; | |
| --secondary: #3dd6c6; | |
| --secondary-foreground: #060910; | |
| --muted: #121824; | |
| --muted-foreground: #7b879c; | |
| --accent: #e8952f; | |
| --accent-foreground: #0a0d14; | |
| --destructive: #f07178; | |
| --border: #1a2233; | |
| --input: #1a2233; | |
| --ring: #e8952f; | |
| --terminal-bg: #05080f; | |
| --terminal-bar: #0a0f18; | |
| --terminal-border: #1c2638; | |
| --terminal-text: #d8e1f0; | |
| --terminal-muted: #6b7f9a; | |
| --terminal-prompt: #e8952f; | |
| --terminal-label: #5a6d88; | |
| --terminal-glow: 0 24px 80px -20px rgba(232, 149, 47, 0.12); | |
| --radius: 0.75rem; | |
| --background: oklch(0.11 0.015 265); | |
| --foreground: oklch(0.96 0.01 265); | |
| --card: oklch(0.16 0.02 265); | |
| --card-foreground: oklch(0.96 0.01 265); | |
| --popover: oklch(0.16 0.02 265); | |
| --popover-foreground: oklch(0.96 0.01 265); | |
| --primary: oklch(0.72 0.18 35); | |
| --primary-foreground: oklch(0.11 0.015 265); | |
| --secondary: oklch(0.65 0.15 195); | |
| --secondary-foreground: oklch(0.96 0.01 265); | |
| --muted: oklch(0.2 0.015 265); | |
| --muted-foreground: oklch(0.58 0.02 265); | |
| --accent: oklch(0.72 0.18 35); | |
| --accent-foreground: oklch(0.11 0.015 265); | |
| --destructive: oklch(0.63 0.2 30); | |
| --border: oklch(0.22 0.015 265); | |
| --input: oklch(0.22 0.015 265); | |
| --ring: oklch(0.72 0.18 35); | |
| --sidebar: oklch(0.16 0.02 265); | |
| --sidebar-foreground: oklch(0.96 0.01 265); | |
| --sidebar-primary: oklch(0.72 0.18 35); | |
| --sidebar-primary-foreground: oklch(0.11 0.015 265); | |
| --sidebar-accent: oklch(0.2 0.015 265); | |
| --sidebar-border: oklch(0.22 0.015 265); | |
| --sidebar-ring: oklch(0.72 0.18 35); | |
| --destructive: oklch(0.63 0.2 30); | |
| --destructive-foreground: oklch(0.96 0.01 265); | |
| --border: oklch(0.22 0.015 265); | |
| --input: oklch(0.22 0.015 265); | |
| --ring: oklch(0.72 0.18 35); | |
| --sidebar: oklch(0.16 0.02 265); | |
| --sidebar-foreground: oklch(0.96 0.01 265); | |
| --sidebar-primary: oklch(0.72 0.18 35); | |
| --sidebar-primary-foreground: oklch(0.11 0.015 265); | |
| --sidebar-accent: oklch(0.2 0.015 265); | |
| --sidebar-accent-foreground: oklch(0.96 0.01 265); | |
| --sidebar-border: oklch(0.22 0.015 265); | |
| --sidebar-ring: oklch(0.72 0.18 35); |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/create-thexjs-app/templates/landing/src/styles/globals.css` around
lines 26 - 68, Add the missing --destructive-foreground and
--sidebar-accent-foreground declarations to the :root block in globals.css,
assigning each a readable foreground color consistent with the existing
destructive and sidebar-accent theme tokens referenced by `@theme` inline.
| @keyframes float { | ||
| 0%, | ||
| 100% { | ||
| transform: translateY(0); | ||
| transform: translateY(0px); | ||
| } | ||
| 50% { | ||
| transform: translateY(-8px); | ||
| transform: translateY(-10px); | ||
| } | ||
| } | ||
|
|
||
| @keyframes pulse-glow { | ||
| 0%, | ||
| 100% { | ||
| opacity: 0.45; | ||
| transform: scale(0.98); | ||
| opacity: 0.6; | ||
| filter: blur(40px); | ||
| } | ||
| 50% { | ||
| opacity: 0.85; | ||
| transform: scale(1); | ||
| } | ||
| } | ||
|
|
||
| @keyframes cursor-blink { | ||
| 0%, | ||
| 100% { | ||
| opacity: 1; | ||
| } | ||
| 50% { | ||
| opacity: 0; | ||
| } | ||
| } | ||
|
|
||
| @media (prefers-reduced-motion: reduce) { | ||
| .animate-pulse-glow, | ||
| .animate-cursor { | ||
| animation: none !important; | ||
| filter: blur(60px); |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Restore reduced-motion handling for looping animations.
The prefers-reduced-motion override was removed along with the cursor-blink animation. animate-float and animate-pulse-glow still loop continuously (e.g., used on the hero glow in index.tsx line 54) with no way to disable them for users who set a reduced-motion preference.
Add back a media query that disables or shortens these animations under prefers-reduced-motion: reduce.
♿ Proposed fix
+@media (prefers-reduced-motion: reduce) {
+ .animate-float,
+ .animate-pulse-glow {
+ animation: none;
+ }
+}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/create-thexjs-app/templates/landing/src/styles/globals.css` around
lines 80 - 98, Add a prefers-reduced-motion: reduce media query in globals.css
targeting the looping float and pulse-glow animation classes, including
animate-float and animate-pulse-glow, and disable or substantially shorten their
animations while preserving normal behavior otherwise.
| `<CodeBlock label="terminal" lang="bash" code={\`bun create x my-app | ||
| cd my-app | ||
| bun run dev\`} />`, | ||
| x dev\`} />`, |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check the scaffolding package's declared name/bin to confirm the correct bun create invocation.
cat packages/create-thexjs-app/package.jsonRepository: abdelkabirouadoukou/x
Length of output: 1394
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== package files =="
git ls-files | rg '(^|/)package.json$|scripts/convert-code-blocks.mjs|bun.lock|bun.lockb|pnpm|yarn|npm' || true
echo
echo "== relevant convert-code-blocks snippets =="
if [ -f scripts/convert-code-blocks.mjs ]; then
wc -l scripts/convert-code-blocks.mjs
sed -n '1,120p' scripts/convert-code-blocks.mjs | cat -n
fi
echo
echo "== mentions of bun create / create-thexjs-app / create-x / thexjs-app =="
rg -n "bun create|create-[^\"'`\\s]+|npm create|yarn create|pnpm create|thexjs-app|x my-app|create-x" . \
--glob '!node_modules/**' --glob '!dist/**' --glob '!build/**' --glob '!coverage/**' || true
echo
echo "== npm registry manifests for relevant packages =="
python3 - <<'PY'
import json, urllib.request
for name in ("create-x", "create-thexjs-app"):
url=f"https://registry.npmjs.org/{name}"
print(f"\n## {name}")
try:
with urllib.request.urlopen(url, timeout=15) as r:
data=json.load(r)
print("exists:", True)
print("latest:", data.get("dist-tags",{}).get("latest"))
if "versions":
for v,data_v in data["versions"].items():
print(v, "bin=", data_v.get("bin"), "name=", data_v.get("name"))
except Exception as e:
print("exists:", False, "error=", repr(e))
PYRepository: abdelkabirouadoukou/x
Length of output: 6660
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== package names and create-related references =="
rg -n '"name"\s*(:|=)|create-thexjs-app|create-x|bun create|npm create|yarn create|pnpm create' package.json packages scripts examples --glob '!node_modules/**' --glob '!dist/**' --glob '!build/**' || true
echo
echo "== npm registry manifests for relevant packages =="
python3 - <<'PY'
import json, urllib.request
for name in ("create-x", "create-thexjs-app"):
url = f"https://registry.npmjs.org/{name}"
print(f"\n## {name}")
try:
with urllib.request.urlopen(url, timeout=15) as r:
data = json.load(r)
print("exists", True)
print("latest", data.get("dist-tags", {}).get("latest"))
if "versions":
for version, meta in data["versions"].items():
print(version, "name=", meta.get("name"), "bin=", meta.get("bin"))
except Exception as e:
print("exists", False, "error=", repr(e))
PY
echo
echo "== root and create package names =="
python3 - <<'PY'
import json
for path in ["package.json", "packages/create-thexjs-app/package.json", "packages/cli/package.json"]:
with open(path) as f:
data = json.load(f)
print(path, json.dumps({"name": data.get("name"), "bin": data.get("bin")}, indent=2))
PYRepository: abdelkabirouadoukou/x
Length of output: 4227
🌐 Web query:
Bun create command npm create template create-template package documentation
💡 Result:
The bun create command is a tool used to scaffold new projects from various sources, including npm packages (prefixed with create-), GitHub repositories, or local file system templates [1][2]. It is an optional tool designed to speed up project initialization; for creating a new empty project, bun init is recommended instead [1][3]. Core Functionality When running bun create [], Bun performs the following steps: 1. Sources the template from an npm package, GitHub, or a local directory [1][2]. 2. Copies files to the destination directory (for local templates, this recursively deletes any existing destination directory first) [1][4]. 3. Updates the name field in the project's package.json to match the destination folder name [1][5]. 4. Removes the bun-create section from the package.json [5]. 5. Executes preinstall and postinstall tasks if defined in the bun-create section of the template's package.json [1][4]. 6. Installs dependencies using the detected npm client (prioritizing pnpm, then yarn v1, then npm) unless the --no-install flag is used [1][3][6]. Custom Local Templates You can create custom local templates by placing them in either $HOME/.bun-create/ (global) or /.bun-create/ (project-specific) [4][5]. The global path can be customized via the BUN_CREATE_DIR environment variable [4]. Setup Logic Templates can define custom setup tasks in their package.json under a bun-create object [4][5]: { "bun-create": { "preinstall": "echo 'Installing...'", "postinstall": ["echo 'Done!'"] } } Command Options Common flags include: --force: Overwrite existing files [1][3]. --no-install: Skip installing node_modules and tasks [1][3]. --no-git: Do not initialize a git repository [1][3]. --open: Start and open in-browser after finish [3][6]. For more details, you can consult the official Bun documentation [1].
Citations:
- 1: https://bun.com/docs/runtime/templating/create
- 2: https://linuxcommandlibrary.com/man/bun-create
- 3: https://github.com/oven-sh/bun/blob/74e191b3/docs/runtime/templating/create.mdx
- 4: https://fossies.org/linux/bun/docs/runtime/templating/create.mdx
- 5: https://solodev.app/installing-bun
- 6: https://github.com/oven-sh/bun/blob/3ed4186bc8db8357c670307f192991bfc263f141/docs/runtime/templating/create.mdx
Use the published create template name in the generated code block.
bun create x looks up create-x, which is not the installed or scaffold template. The repo declares create-thexjs-app, and the source command is bun create thexjs-app@latest my-app; keep the generated command matching that template name.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@scripts/convert-code-blocks.mjs` around lines 42 - 44, Update the generated
CodeBlock command in the conversion output to use the published scaffold
template: replace the bun create target with thexjs-app@latest while preserving
the my-app argument and subsequent commands.
…dapter-vercel as workspace dependency
- changeset: scope the 'no embedded literals' claim to masked quoted strings; note the template-tag path binds values out-of-band (#1) - cli: serialize Tailwind recompiles so saves coalesce into one follow-up run after the active compile exits, instead of stacking overlapping processors writing the same output (#8); unit test proves no two compiles overlap, verified to fail against the old concurrent spawn - redact: capture the authorization/auth keyword group so it survives the $1 replacement instead of emitting a literal '$1 [REDACTED]' (#9); exact-output regression test verified against the old non-capturing regex - tracing: stop double-recording a throwing handler error on the x.http root span (the wrapper's fail() plus runWithRequestSpan's catch) (#11); mask quoted SQL string literals to '?' in db.statement (#13) — both verified failing against the previous behavior - redis rate-limit test: FakeRedis PTTL now validates its key argument instead of silently modeling a malformed call as a missing key (#15) - auth: empty-identifier regression test now provably fails against the old shared `login:` account key (auth.ts skip logic and brute-force namespacing both reverted to confirm); IP-bucket test rewritten so the attacker's own successful login must NOT reset the spray counter (verified it fails when the success path clears the IP bucket)
… (#141) * feat(core): request-scoped OpenTelemetry tracing correlation (#79) @thexjs/core never initializes OpenTelemetry itself — apps opt in by calling setTracer() (or getTracer()) with any tracer whose startSpan(name, { attributes }) matches the OTel surface. Without a configured tracer the layer degrades to synchronous no-ops. Every request opens an x.http root span carrying the x.requestId attribute plus route/method/status; with no inbound x-request-id, one is minted and shared via traceRequestId() so the log line, the response header and the trace span all agree. Request-scoped phase spans cover the whole pipeline, all correlated by x.requestId: x.api (API routes), x.loader (page loaders + SSR/SSG), x.action (server functions), x.middleware (composed onion + handler), x.ssr, and x.db (both connectSQLite and connectPostgres, wrapping query/run/execute/template-tag calls with db.system, db.operation and a redacted + truncated db.statement). Errors inside any span set ERROR and record an exception. runWithRequestSpan, tracePhase, tracePhaseSync, dbTraceAttributes, TraceSpan and TracerLike are exported. Mock-tracer tests cover a failing DB call carrying the request id, phase spans, error status propagation and the full createApp request lifecycle. * fix(core): reject hydration beacons from prefix-matching or opaque origins (#138) The hydration-mismatch beacon used a prefix match on the canonical origin, so Origin: https://localhost.evil.com passed (not just https://localhost). Exact-match now: the header is parsed via originFromHeader and compared as a full origin string, and a present-but-unparseable header (Origin: null from a sandboxed/opaque origin) is treated as cross-site rather than absent. Regression tests cover the evil-prefix origin and Origin: null. * fix(core): deterministic routing when dynamic routes tie (#140) Same-category route ties (e.g. /bar/[b] vs /[a]/foo both matching /bar/foo) were left to the OS's directory-scan order, so a build could serve different pages on different platforms. Ties are now broken segment-by-segment by positional specificity (literal 0 > param 1 > catch-all 2), falling back to a lexical routePath sort — deterministic everywhere and documented in the core README. Regression test with both fixture routes active. * fix(core): serialize concurrent Postgres migrations with an advisory lock (#131) runPostgresMigrations now runs inside one client.begin() transaction holding SELECT pg_advisory_xact_lock(MIGRATION_LOCK_KEY), so a second process racing the same migration set can't double-apply or interleave DDL. The applied-tracking read happens under the lock, migrations use savepoints, and a failure rolls back only its own migration while prior successes keep their commit. Concurrency regression test added. * fix(core): pin image-proxy fetch to the verified public IP to close the DNS-rebinding TOCTOU (#132) The allow-listed hostname was resolved once for validation but the actual fetch re-resolved it, so the DNS answer for the fetch could differ (a second lookup rebinding to a private address). The target is now resolved a single time: private/reserved literals are rejected, every DNS answer must be public, and the first public IP is pinned into the fetch via the Host header + tls.serverName with redirect: manual. Each redirect hop re-resolves and re-pins before connecting. Tests cover pinning on first fetch and on every hop. * fix(auth): rate-guess spraying across IPs with separate account and IP buckets (#133) Brute-force was keyed by (IP, identifier), so rotating source IPs reset the throttle. createBruteForceGuard now maintains two independent buckets — an account bucket (identifier alone) stopping guessing one account from many IPs, and an IP bucket (client IP) stopping one IP spraying many accounts — checked together, failed/reset together, with Retry-After reflecting the longer window. Tests updated and extended for the two-bucket behavior. * fix(core): generated href() now fills catch-all params instead of dropping them (#134) A catch-all like /docs/* compiles to a * token with no :slug to substitute, so href('/docs/*', { slug }) only stripped the * and returned '/docs/'. The generated href() now substitutes * segments in param order with the value (segments encoded individually so multi-segment values keep their slashes). New runtime test imports the generated manifest and asserts catch-all, param and static href calls. * fix(core): Redis rate-limiter reports the real window reset, not a sliding one (#135) The Redis store returned resetAt = Date.now() + windowMs on every call, so Retry-After kept sliding forward instead of converging on the TTL the EXPIRE enforces. incr() now reads PTTL right after INCR (clamped to >= 0) and derives resetAt from the key's actual remaining life. FakeRedis models PTTL and a regression test verifies a mid-window key reports ~remaining, not the full window; verified it fails against the old implementation. * fix(core): mask connection-string passwords in log redaction (#136) redactString already masked bearer/basic credentials and inline Authorization values but not URI userinfo, so postgres://deploy:supersecret@db:5432/app printed the password. Redaction now masks the userinfo password for any scheme (http, postgres, mysql, redis, ...) via a scheme://user:pass@ shape regex, leaving password-less URLs untouched. Regression tests added for the common drivers. * fix(cli): keep dev server responsive during Tailwind recompiles and exit promptly on SIGTERM (#137, #139) Dev-mode Tailwind recompilation used an async spawn but awaited it synchronously, stalling request handling until the (potentially multi-second) recompile finished; the watcher path now uses a true async compile so the server stays responsive mid-build. shutdown() awaited server.stop(true) inside the 3s window, so a SIGTERM that arrived with nothing left to drain still waited the full grace period — it now stops immediately and the timer is a hard-cap fallback (unref'd). E2E tests cover both: a fake-slow bunx keeping the dev server under 1s, and prompt SIGTERM exit. * fix(core): lock bookkeeping-table creation in Postgres migrations (#131) The _x_migrations table was created via CREATE TABLE IF NOT EXISTS before the advisory lock, so two booting replicas raced that DDL and hit Postgres's simultaneous-create catalog race (pg_type_typname_nsp_index) before serialization kicked in. Moving the table creation inside the locked transaction means the loser instead finds the table the winner committed and proceeds to skip — the advisory lock now guards the entire run. * fix: finish CodeRabbit review on tracing PR (#141, #79, #131-#140) - changeset: scope the 'no embedded literals' claim to masked quoted strings; note the template-tag path binds values out-of-band (#1) - cli: serialize Tailwind recompiles so saves coalesce into one follow-up run after the active compile exits, instead of stacking overlapping processors writing the same output (#8); unit test proves no two compiles overlap, verified to fail against the old concurrent spawn - redact: capture the authorization/auth keyword group so it survives the $1 replacement instead of emitting a literal '$1 [REDACTED]' (#9); exact-output regression test verified against the old non-capturing regex - tracing: stop double-recording a throwing handler error on the x.http root span (the wrapper's fail() plus runWithRequestSpan's catch) (#11); mask quoted SQL string literals to '?' in db.statement (#13) — both verified failing against the previous behavior - redis rate-limit test: FakeRedis PTTL now validates its key argument instead of silently modeling a malformed call as a missing key (#15) - auth: empty-identifier regression test now provably fails against the old shared `login:` account key (auth.ts skip logic and brute-force namespacing both reverted to confirm); IP-bucket test rewritten so the attacker's own successful login must NOT reset the spray counter (verified it fails when the success path clears the IP bucket)
* feat(core): request-scoped OpenTelemetry tracing correlation (#79) @thexjs/core never initializes OpenTelemetry itself — apps opt in by calling setTracer() (or getTracer()) with any tracer whose startSpan(name, { attributes }) matches the OTel surface. Without a configured tracer the layer degrades to synchronous no-ops. Every request opens an x.http root span carrying the x.requestId attribute plus route/method/status; with no inbound x-request-id, one is minted and shared via traceRequestId() so the log line, the response header and the trace span all agree. Request-scoped phase spans cover the whole pipeline, all correlated by x.requestId: x.api (API routes), x.loader (page loaders + SSR/SSG), x.action (server functions), x.middleware (composed onion + handler), x.ssr, and x.db (both connectSQLite and connectPostgres, wrapping query/run/execute/template-tag calls with db.system, db.operation and a redacted + truncated db.statement). Errors inside any span set ERROR and record an exception. runWithRequestSpan, tracePhase, tracePhaseSync, dbTraceAttributes, TraceSpan and TracerLike are exported. Mock-tracer tests cover a failing DB call carrying the request id, phase spans, error status propagation and the full createApp request lifecycle. * fix(core): reject hydration beacons from prefix-matching or opaque origins (#138) The hydration-mismatch beacon used a prefix match on the canonical origin, so Origin: https://localhost.evil.com passed (not just https://localhost). Exact-match now: the header is parsed via originFromHeader and compared as a full origin string, and a present-but-unparseable header (Origin: null from a sandboxed/opaque origin) is treated as cross-site rather than absent. Regression tests cover the evil-prefix origin and Origin: null. * fix(core): deterministic routing when dynamic routes tie (#140) Same-category route ties (e.g. /bar/[b] vs /[a]/foo both matching /bar/foo) were left to the OS's directory-scan order, so a build could serve different pages on different platforms. Ties are now broken segment-by-segment by positional specificity (literal 0 > param 1 > catch-all 2), falling back to a lexical routePath sort — deterministic everywhere and documented in the core README. Regression test with both fixture routes active. * fix(core): serialize concurrent Postgres migrations with an advisory lock (#131) runPostgresMigrations now runs inside one client.begin() transaction holding SELECT pg_advisory_xact_lock(MIGRATION_LOCK_KEY), so a second process racing the same migration set can't double-apply or interleave DDL. The applied-tracking read happens under the lock, migrations use savepoints, and a failure rolls back only its own migration while prior successes keep their commit. Concurrency regression test added. * fix(core): pin image-proxy fetch to the verified public IP to close the DNS-rebinding TOCTOU (#132) The allow-listed hostname was resolved once for validation but the actual fetch re-resolved it, so the DNS answer for the fetch could differ (a second lookup rebinding to a private address). The target is now resolved a single time: private/reserved literals are rejected, every DNS answer must be public, and the first public IP is pinned into the fetch via the Host header + tls.serverName with redirect: manual. Each redirect hop re-resolves and re-pins before connecting. Tests cover pinning on first fetch and on every hop. * fix(auth): rate-guess spraying across IPs with separate account and IP buckets (#133) Brute-force was keyed by (IP, identifier), so rotating source IPs reset the throttle. createBruteForceGuard now maintains two independent buckets — an account bucket (identifier alone) stopping guessing one account from many IPs, and an IP bucket (client IP) stopping one IP spraying many accounts — checked together, failed/reset together, with Retry-After reflecting the longer window. Tests updated and extended for the two-bucket behavior. * fix(core): generated href() now fills catch-all params instead of dropping them (#134) A catch-all like /docs/* compiles to a * token with no :slug to substitute, so href('/docs/*', { slug }) only stripped the * and returned '/docs/'. The generated href() now substitutes * segments in param order with the value (segments encoded individually so multi-segment values keep their slashes). New runtime test imports the generated manifest and asserts catch-all, param and static href calls. * fix(core): Redis rate-limiter reports the real window reset, not a sliding one (#135) The Redis store returned resetAt = Date.now() + windowMs on every call, so Retry-After kept sliding forward instead of converging on the TTL the EXPIRE enforces. incr() now reads PTTL right after INCR (clamped to >= 0) and derives resetAt from the key's actual remaining life. FakeRedis models PTTL and a regression test verifies a mid-window key reports ~remaining, not the full window; verified it fails against the old implementation. * fix(core): mask connection-string passwords in log redaction (#136) redactString already masked bearer/basic credentials and inline Authorization values but not URI userinfo, so postgres://deploy:supersecret@db:5432/app printed the password. Redaction now masks the userinfo password for any scheme (http, postgres, mysql, redis, ...) via a scheme://user:pass@ shape regex, leaving password-less URLs untouched. Regression tests added for the common drivers. * fix(cli): keep dev server responsive during Tailwind recompiles and exit promptly on SIGTERM (#137, #139) Dev-mode Tailwind recompilation used an async spawn but awaited it synchronously, stalling request handling until the (potentially multi-second) recompile finished; the watcher path now uses a true async compile so the server stays responsive mid-build. shutdown() awaited server.stop(true) inside the 3s window, so a SIGTERM that arrived with nothing left to drain still waited the full grace period — it now stops immediately and the timer is a hard-cap fallback (unref'd). E2E tests cover both: a fake-slow bunx keeping the dev server under 1s, and prompt SIGTERM exit. * fix(core): lock bookkeeping-table creation in Postgres migrations (#131) The _x_migrations table was created via CREATE TABLE IF NOT EXISTS before the advisory lock, so two booting replicas raced that DDL and hit Postgres's simultaneous-create catalog race (pg_type_typname_nsp_index) before serialization kicked in. Moving the table creation inside the locked transaction means the loser instead finds the table the winner committed and proceeds to skip — the advisory lock now guards the entire run. * fix: finish CodeRabbit review on tracing PR (#141, #79, #131-#140) - changeset: scope the 'no embedded literals' claim to masked quoted strings; note the template-tag path binds values out-of-band (#1) - cli: serialize Tailwind recompiles so saves coalesce into one follow-up run after the active compile exits, instead of stacking overlapping processors writing the same output (#8); unit test proves no two compiles overlap, verified to fail against the old concurrent spawn - redact: capture the authorization/auth keyword group so it survives the $1 replacement instead of emitting a literal '$1 [REDACTED]' (#9); exact-output regression test verified against the old non-capturing regex - tracing: stop double-recording a throwing handler error on the x.http root span (the wrapper's fail() plus runWithRequestSpan's catch) (#11); mask quoted SQL string literals to '?' in db.statement (#13) — both verified failing against the previous behavior - redis rate-limit test: FakeRedis PTTL now validates its key argument instead of silently modeling a malformed call as a missing key (#15) - auth: empty-identifier regression test now provably fails against the old shared `login:` account key (auth.ts skip logic and brute-force namespacing both reverted to confirm); IP-bucket test rewritten so the attacker's own successful login must NOT reset the spray counter (verified it fails when the success path clears the IP bucket) * fix(release): bump changesets/action to v2 for changesets CLI v3 changesets/action@v1 detects published packages by parsing the publish command's stdout for 'New tag:' lines, which @changesets/cli v3 no longer prints. Since the CLI was bumped to v3.0.0 (#55), npm publishes succeeded but the action never pushed git tags or created GitHub releases. v2 reads the CHANGESETS_OUTPUT event file the CLI writes instead and fails loudly if that output is missing. Rename the custom-script inputs to their v2 names (version-script, publish-script, pr-title, commit-message).
fix: improve server functions documentation for clarity
chore: update feature descriptions for consistency
style: enhance homepage layout and styling for better user experience
style: update global styles and animations for improved aesthetics
fix: correct package version for @thexjs/env
feat: add contact page with form for user inquiries
chore: add TypeScript configuration for @thexjs/env package
fix: adjust button attributes in settings page for consistency
Summary by CodeRabbit
New Features
Documentation
Style
Security