Skip to content

Specify source build location before globbing #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

grantseltzer
Copy link

@grantseltzer grantseltzer commented Aug 8, 2017

Prior to to the soon to be released go 1.9, the ... file glob symbol does not exclude the vendor directory. By not specifying cmd the build script will attempt to build vendor.

By adding cmd to the install line, only build-able packages will be touched by build.sh

Signed-off-by: grantseltzer [email protected]

@grantseltzer
Copy link
Author

@thockin Any feedback on this?

@thockin
Copy link
Owner

thockin commented Aug 20, 2017

Sorry, it turns out I have to "watch" my own repos, or I never get notifications of stuff like this. Looking now.

@thockin
Copy link
Owner

thockin commented Aug 20, 2017

With this change, none of the .a files in any directory get "installed" which will cause serious build slowdowns as those get relinked on subsequent builds.

What is the problem caused by building vendor?

@grantseltzer
Copy link
Author

Ah, yea those should be included. Got to fix this to only exclude vendor.

The issue with building vendor is that it's unnecessary. Without this change go build will look for build-able sources in vendor and actually do so.

I believe this often goes unnoticed. The way I realized is that dep was pulling in all necessary dependencies for what is actually supposed to be built but then this line in build.sh was saying I was missing stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants