Add rtnl_nh_add() API #441
Merged
+726
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thom311
reviewed
Aug 5, 2025
For improved error-output. Signed-off-by: Christoph Paasch <[email protected]>
Test as much as possible, positive and negative conditions. Signed-off-by: Christoph Paasch <[email protected]>
This allows to push the nexthop to the kernel. Similar to `ip nexthop add` command. Signed-off-by: Christoph Paasch <[email protected]>
We want to test whether rtnl_nh_add generates the right netlink messages and whether querying the kernel is able to properly parse the netlink messages. Thus, do a kernel-roundtrip. Signed-off-by: Christoph Paasch <[email protected]>
cpaasch-oai
force-pushed
the
t/rtnl_nh_add
branch
from
c46fa32 to
996f617
Compare
Owner
|
thank you for all the tests. This is really nice!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to support pushing a rtnl_nh down to the kernel through netlink, similar to what
ip nexthop adddoes.A few additional things in this PR (1 bugfix, some more tests for getters/setters and adding support for ENETDOWN). Let me know if I should split it in separate PRs - I don't want to create overhead for you @thom311 .
f4d68e9 adds an extensive testsuite for the rtnl_nh getters/setters. All in user-space. As part of adding this work, one bug was identified (fixed with 87c7af1).
79d1abd adds another error-code for ENETDOWN, which turned out to be useful when testing the kernel round-trip for rtnl_nh_add.
933edc3 actually adds the rtnl_nh_add() call.
c46fa32 tries to be a complete test-suite for the rtnl_nh_add() call as well as fetching nexthop objects (and parsing the netlink message) from the kernel.