Update Microsoft Testing Platform to v2

[thomhurst]

Fixes #3336

[claude]

Claude finished @thomhurst's task —— View job

---

Pull Request Review: Update Microsoft Testing Platform to v2

Review Tasks:

• Read and analyze all changed files
• Review Directory.Packages.props for dependency updates
• Review TestExtensions.cs for API changes
• Review TUnitFrameworkLogger.cs for logging changes
• Review TUnitMessageBus.cs for messaging changes
• Assess code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Review security implications
• Assess test coverage needs
• Provide comprehensive feedback

Review Summary

This PR successfully updates Microsoft Testing Platform from v1.9.0 to v2.0.1, addressing breaking API changes with clean adaptations. The changes are well-implemented and maintain backward compatibility for TUnit users.

✅ Positive Aspects

1. Comprehensive Dependency Update: All MTP-related packages updated consistently to v2.0.1
2. Clean API Adaptation: Properly adapted to breaking changes in MTP v2 API
3. Backward Compatibility: Changes are internal and won't affect TUnit user experience
4. Performance Conscious: CancellationToken.None additions are appropriate for async operations

📋 Code Quality Assessment

Directory.Packages.props ✅

• Good: Consistent version updates across all MTP packages
• Good: Proper central package management usage

TestExtensions.cs ✅

• Good: Constructor parameter names changed from PascalCase to camelCase (follows MTP v2 API)
• Good: Maintains all existing functionality while adapting to new API

TUnitFrameworkLogger.cs ✅

• Good: Added required CancellationToken.None parameters to DisplayAsync calls
• Good: Async operations now properly include cancellation tokens

TUnitMessageBus.cs ✅

• Good: Updated from generic TrxMessage to specific DebugOrTraceTrxMessage type
• Good: Maintains semantic correctness - skip reasons are debug/trace information

🔍 Detailed Analysis

No Breaking Changes: All modifications are internal API adaptations that don't affect public TUnit APIs.

Performance Impact: Minimal to none. The CancellationToken.None additions are standard practice and the TrxMessage type change is a pure rename.

Security: No security implications - these are API compatibility changes.

Test Coverage: No additional test coverage needed as this is a dependency update with equivalent functionality.

🎯 Recommendations

1. ✅ Approve and Merge: This is a clean dependency update with proper API adaptations
2. Consider Testing: Run the full test suite to ensure no regressions, especially integration tests with the testing platform
3. Documentation: If there are any user-facing benefits from MTP v2, consider mentioning them in release notes

🔧 Technical Notes

The changes correctly address MTP v2 breaking changes:

• Constructor parameter naming convention changes
• Required cancellation token parameters for async display operations
• TrxMessage type system refinements

All adaptations follow TUnit's established patterns and maintain the framework's performance-first philosophy.

Overall Assessment: This is a well-executed dependency update that properly handles breaking changes while maintaining TUnit's functionality and performance characteristics.

---

[claude]

Claude finished @thomhurst's task —— View job

---

Pull Request Review: Update Microsoft Testing Platform to v2

Review Tasks:

• Read and analyze all changed files
• Review Directory.Packages.props for dependency updates
• Review TestExtensions.cs for API changes
• Review TUnitFrameworkLogger.cs for logging changes
• Review TUnitMessageBus.cs for messaging changes
• Assess code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Review security implications
• Assess test coverage needs
• Provide comprehensive feedback

Review Summary

This PR successfully updates Microsoft Testing Platform from v1.9.0 to v2.0.1, addressing breaking API changes with clean adaptations. The changes are well-implemented and maintain backward compatibility for TUnit users.

✅ Positive Aspects

1. Comprehensive Dependency Update: All MTP-related packages updated consistently to v2.0.1
2. Clean API Adaptation: Properly adapted to breaking changes in MTP v2 API
3. Backward Compatibility: Changes are internal and won't affect TUnit user experience
4. Performance Conscious: CancellationToken.None additions are appropriate for async operations

📋 Code Quality Assessment

Directory.Packages.props ✅

• Good: Consistent version updates across all MTP packages
• Good: Proper central package management usage

TestExtensions.cs ✅

• Good: Constructor parameter names changed from PascalCase to camelCase (follows MTP v2 API)
• Good: Maintains all existing functionality while adapting to new API

TUnitFrameworkLogger.cs ✅

• Good: Added required CancellationToken.None parameters to DisplayAsync calls
• Good: Async operations now properly include cancellation tokens

TUnitMessageBus.cs ✅

• Good: Updated from generic TrxMessage to specific DebugOrTraceTrxMessage type
• Good: Maintains semantic correctness - skip reasons are debug/trace information

🔍 Detailed Analysis

No Breaking Changes: All modifications are internal API adaptations that don't affect public TUnit APIs.

Performance Impact: Minimal to none. The CancellationToken.None additions are standard practice and the TrxMessage type change is a pure rename.

Security: No security implications - these are API compatibility changes.

Test Coverage: No additional test coverage needed as this is a dependency update with equivalent functionality.

🎯 Recommendations

1. ✅ Approve and Merge: This is a clean dependency update with proper API adaptations
2. Consider Testing: Run the full test suite to ensure no regressions, especially integration tests with the testing platform
3. Documentation: If there are any user-facing benefits from MTP v2, consider mentioning them in release notes

🔧 Technical Notes

The changes correctly address MTP v2 breaking changes:

• Constructor parameter naming convention changes
• Required cancellation token parameters for async display operations
• TrxMessage type system refinements

All adaptations follow TUnit's established patterns and maintain the framework's performance-first philosophy.

Overall Assessment: This is a well-executed dependency update that properly handles breaking changes while maintaining TUnit's functionality and performance characteristics.

---

[claude]

Claude finished @thomhurst's task —— View job

---

Pull Request Review: Update Microsoft Testing Platform to v2

Review Tasks:

• Read and analyze all changed files
• Review Directory.Packages.props for dependency updates
• Review TestExtensions.cs for API changes
• Review TUnitFrameworkLogger.cs for logging changes
• Review TUnitMessageBus.cs for messaging changes
• Review pipeline module changes
• Review dotnet.config addition
• Assess code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Review security implications
• Assess test coverage needs
• Provide comprehensive feedback

Review Summary

This PR successfully updates Microsoft Testing Platform from v1.9.0 to v2.0.1, addressing breaking API changes with clean adaptations. The changes are well-implemented and maintain backward compatibility for TUnit users.

✅ Positive Aspects

1. Comprehensive Dependency Update: All MTP-related packages updated consistently to v2.0.1
2. Clean API Adaptation: Properly adapted to breaking changes in MTP v2 API
3. Backward Compatibility: Changes are internal and won't affect TUnit user experience
4. Performance Conscious: CancellationToken.None additions are appropriate for async operations
5. Proper Configuration: Addition of dotnet.config follows MTP v2 best practices

📋 Code Quality Assessment

Directory.Packages.props ✅

• Good: Consistent version updates across all MTP packages (lines 41-46)
• Good: Proper central package management usage

TestExtensions.cs ✅

• Good: Constructor parameter names changed from PascalCase to camelCase (follows MTP v2 API)
• Good: Maintains all existing functionality while adapting to new API
• Good: Efficient parameter type array creation (lines 70-83)

TUnitFrameworkLogger.cs ✅

• Good: Added required CancellationToken.None parameters to DisplayAsync calls (lines 37, 57)
• Good: Async operations now properly include cancellation tokens

TUnitMessageBus.cs ✅

• Good: Updated from generic TrxMessage to specific DebugOrTraceTrxMessage type (line 208)
• Good: Maintains semantic correctness - skip reasons are debug/trace information

Pipeline Modules ✅

• Good: Added WorkingDirectory property to DotNetTestOptions for better build isolation
• Good: Consistent pattern across all test modules
• Good: Follows TUnit's performance-first philosophy

dotnet.config ✅

• Good: Properly configures Microsoft Testing Platform as the test runner
• Good: Follows MTP v2 configuration standards

🔍 Detailed Analysis

No Breaking Changes: All modifications are internal API adaptations that don't affect public TUnit APIs.

Performance Impact: Minimal to none. The CancellationToken.None additions are standard practice and the TrxMessage type change is a pure rename.

Security: No security implications - these are API compatibility changes.

Test Coverage: No additional test coverage needed as this is a dependency update with equivalent functionality.

AOT/Trimming Compatibility: Changes maintain compatibility with TUnit's AOT/trimming support requirements.

🎯 Recommendations

1. ✅ Approve and Merge: This is a clean dependency update with proper API adaptations
2. Consider Testing: Run the full test suite to ensure no regressions, especially integration tests with the testing platform
3. Documentation: If there are any user-facing benefits from MTP v2, consider mentioning them in release notes

🔧 Technical Notes

The changes correctly address MTP v2 breaking changes:

• Constructor parameter naming convention changes (TestFileLocationProperty, TestMethodIdentifierProperty)
• Required cancellation token parameters for async display operations
• TrxMessage type system refinements (DebugOrTraceTrxMessage vs TrxMessage)
• WorkingDirectory configuration for better test isolation

All adaptations follow TUnit's established patterns and maintain the framework's performance-first philosophy outlined in CLAUDE.md.

Overall Assessment: This is a well-executed dependency update that properly handles breaking changes while maintaining TUnit's functionality and performance characteristics. The changes align with TUnit's dual-mode implementation requirements and performance guidelines.

---

[claude]

Claude finished @thomhurst's task —— View job

---

Pull Request Review: Update Microsoft Testing Platform to v2

Review Tasks:

• Read and analyze all changed files
• Review Directory.Packages.props for dependency updates
• Review TestExtensions.cs for API changes
• Review TUnitFrameworkLogger.cs for logging changes
• Review TUnitMessageBus.cs for messaging changes
• Review pipeline module changes
• Review dotnet.config addition
• Assess code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Review security implications
• Assess test coverage needs
• Provide comprehensive feedback

Review Summary

This PR successfully updates Microsoft Testing Platform from v1.9.0 to v2.0.1, addressing breaking API changes with clean adaptations. The changes are well-implemented and maintain backward compatibility for TUnit users.

✅ Positive Aspects

1. Comprehensive Dependency Update: All MTP-related packages updated consistently to v2.0.1
2. Clean API Adaptation: Properly adapted to breaking changes in MTP v2 API
3. Backward Compatibility: Changes are internal and won't affect TUnit user experience
4. Performance Conscious: CancellationToken.None additions are appropriate for async operations
5. Proper Configuration: Addition of dotnet.config follows MTP v2 best practices

📋 Code Quality Assessment

Directory.Packages.props ✅

• Good: Consistent version updates across all MTP packages (lines 41-46)
• Good: Proper central package management usage

TestExtensions.cs ✅

• Good: Constructor parameter names changed from PascalCase to camelCase (follows MTP v2 API)
• Good: Maintains all existing functionality while adapting to new API
• Good: Efficient parameter type array creation (lines 70-83)

TUnitFrameworkLogger.cs ✅

• Good: Added required CancellationToken.None parameters to DisplayAsync calls (lines 37, 57)
• Good: Async operations now properly include cancellation tokens

TUnitMessageBus.cs ✅

• Good: Updated from generic TrxMessage to specific DebugOrTraceTrxMessage type (line 208)
• Good: Maintains semantic correctness - skip reasons are debug/trace information

Pipeline Modules ✅

• Good: Added WorkingDirectory property to DotNetTestOptions for better build isolation
• Good: Consistent pattern across all test modules
• Good: Follows TUnit's performance-first philosophy

dotnet.config ✅

• Good: Properly configures Microsoft Testing Platform as the test runner
• Good: Follows MTP v2 configuration standards

🔍 Detailed Analysis

No Breaking Changes: All modifications are internal API adaptations that don't affect public TUnit APIs.

Performance Impact: Minimal to none. The CancellationToken.None additions are standard practice and the TrxMessage type change is a pure rename.

Security: No security implications - these are API compatibility changes.

Test Coverage: No additional test coverage needed as this is a dependency update with equivalent functionality.

AOT/Trimming Compatibility: Changes maintain compatibility with TUnit's AOT/trimming support requirements.

🎯 Recommendations

1. ✅ Approve and Merge: This is a clean dependency update with proper API adaptations
2. Consider Testing: Run the full test suite to ensure no regressions, especially integration tests with the testing platform
3. Documentation: If there are any user-facing benefits from MTP v2, consider mentioning them in release notes

🔧 Technical Notes

The changes correctly address MTP v2 breaking changes:

• Constructor parameter naming convention changes (TestFileLocationProperty, TestMethodIdentifierProperty)
• Required cancellation token parameters for async display operations
• TrxMessage type system refinements (DebugOrTraceTrxMessage vs TrxMessage)
• WorkingDirectory configuration for better test isolation

All adaptations follow TUnit's established patterns and maintain the framework's performance-first philosophy outlined in CLAUDE.md.

Overall Assessment: This is a well-executed dependency update that properly handles breaking changes while maintaining TUnit's functionality and performance characteristics. The changes align with TUnit's dual-mode implementation requirements and performance guidelines.

---

[claude]

Claude finished @thomhurst's task —— View job

---

Pull Request Review: Update Microsoft Testing Platform to v2

Review Tasks:

• Read and analyze all changed files
• Review Directory.Packages.props for dependency updates
• Review TestExtensions.cs for API changes
• Review TUnitFrameworkLogger.cs for logging changes
• Review TUnitMessageBus.cs for messaging changes
• Review pipeline module changes
• Review dotnet.config addition
• Assess code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Review security implications
• Assess test coverage needs
• Provide comprehensive feedback

Review Summary

This PR successfully updates Microsoft Testing Platform from v1.9.0 to v2.0.1, addressing breaking API changes with clean adaptations. The changes are well-implemented and maintain backward compatibility for TUnit users.

✅ Positive Aspects

1. Comprehensive Dependency Update: All MTP-related packages updated consistently to v2.0.1
2. Clean API Adaptation: Properly adapted to breaking changes in MTP v2 API
3. Backward Compatibility: Changes are internal and won't affect TUnit user experience
4. Performance Conscious: CancellationToken.None additions are appropriate for async operations
5. Proper Configuration: Addition of dotnet.config follows MTP v2 best practices

📋 Code Quality Assessment

Directory.Packages.props ✅

• Good: Consistent version updates across all MTP packages (lines 41-46)
• Good: Proper central package management usage

TestExtensions.cs ✅

• Good: Constructor parameter names changed from PascalCase to camelCase (follows MTP v2 API)
• Good: Maintains all existing functionality while adapting to new API
• Good: Efficient parameter type array creation (lines 70-83)

TUnitFrameworkLogger.cs ✅

• Good: Added required CancellationToken.None parameters to DisplayAsync calls (lines 37, 57)
• Good: Async operations now properly include cancellation tokens

TUnitMessageBus.cs ✅

• Good: Updated from generic TrxMessage to specific DebugOrTraceTrxMessage type (line 208)
• Good: Maintains semantic correctness - skip reasons are debug/trace information

Pipeline Modules ✅

• Good: Added WorkingDirectory property to DotNetTestOptions for better build isolation
• Good: Consistent pattern across all test modules
• Good: Follows TUnit's performance-first philosophy

dotnet.config ✅

• Good: Properly configures Microsoft Testing Platform as the test runner
• Good: Follows MTP v2 configuration standards

🔍 Detailed Analysis

No Breaking Changes: All modifications are internal API adaptations that don't affect public TUnit APIs.

Performance Impact: Minimal to none. The CancellationToken.None additions are standard practice and the TrxMessage type change is a pure rename.

Security: No security implications - these are API compatibility changes.

Test Coverage: No additional test coverage needed as this is a dependency update with equivalent functionality.

AOT/Trimming Compatibility: Changes maintain compatibility with TUnit's AOT/trimming support requirements.

🎯 Recommendations

1. ✅ Approve and Merge: This is a clean dependency update with proper API adaptations
2. Consider Testing: Run the full test suite to ensure no regressions, especially integration tests with the testing platform
3. Documentation: If there are any user-facing benefits from MTP v2, consider mentioning them in release notes

🔧 Technical Notes

The changes correctly address MTP v2 breaking changes:

• Constructor parameter naming convention changes (TestFileLocationProperty, TestMethodIdentifierProperty)
• Required cancellation token parameters for async display operations
• TrxMessage type system refinements (DebugOrTraceTrxMessage vs TrxMessage)
• WorkingDirectory configuration for better test isolation

All adaptations follow TUnit's established patterns and maintain the framework's performance-first philosophy outlined in CLAUDE.md.

Overall Assessment: This is a well-executed dependency update that properly handles breaking changes while maintaining TUnit's functionality and performance characteristics. The changes align with TUnit's dual-mode implementation requirements and performance guidelines.

---