Skip to content

perf: consolidate per-method TestSource into per-class TestSource (~27k fewer JITs) #5049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Mar 2, 2026
Merged

perf: consolidate per-method TestSource into per-class TestSource (~27k fewer JITs) #5049

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
429c527
perf: consolidate per-method TestSource into per-class TestSource to …
thomhurst Mar 2, 2026
5099ed7
refactor: address review feedback on per-class TestSource
thomhurst Mar 2, 2026
d9382f3
fix: preserve blank lines in CodeWriter.AppendRaw
thomhurst Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 54 additions & 25 deletions TUnit.Core.SourceGenerator.Tests/AbstractTests.Concrete2.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@
namespace TUnit.Generated;
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverageAttribute]
[global::System.CodeDom.Compiler.GeneratedCode("TUnit", "1.0.0.0")]
internal sealed class TUnit_TestProject_AbstractTests_ConcreteClass2_SecondTest_TestSource : global::TUnit.Core.Interfaces.SourceGenerator.ITestSource, global::TUnit.Core.Interfaces.SourceGenerator.ITestDescriptorSource
internal sealed class TUnit_TestProject_AbstractTests_ConcreteClass2__TestSource : global::TUnit.Core.Interfaces.SourceGenerator.ITestSource, global::TUnit.Core.Interfaces.SourceGenerator.ITestDescriptorSource
{
public global::System.Collections.Generic.IReadOnlyList<global::TUnit.Core.TestMetadata> GetTests(string testSessionId)
{
var metadata = new global::TUnit.Core.TestMetadata<global::TUnit.TestProject.AbstractTests.ConcreteClass2>
var metadata_SecondTest = new global::TUnit.Core.TestMetadata<global::TUnit.TestProject.AbstractTests.ConcreteClass2>
{
TestName = "SecondTest",
TestClassType = typeof(global::TUnit.TestProject.AbstractTests.ConcreteClass2),
TestMethodName = "SecondTest",
Dependencies = global::System.Array.Empty<global::TUnit.Core.TestDependency>(),
AttributeFactory = __CreateAttributes,
AttributeFactory = __CreateAttributes_0,
DataSources = global::System.Array.Empty<global::TUnit.Core.IDataSourceAttribute>(),
ClassDataSources = global::System.Array.Empty<global::TUnit.Core.IDataSourceAttribute>(),
PropertyDataSources = global::System.Array.Empty<global::TUnit.Core.PropertyDataSource>(),
Expand Down Expand Up @@ -44,11 +44,11 @@ internal sealed class TUnit_TestProject_AbstractTests_ConcreteClass2_SecondTest_
Parent = null
})
},
InstanceFactory = TUnit_TestProject_AbstractTests_ConcreteClass2__ClassHelper.CreateInstance,
InvokeTypedTest = __InvokeTest,
InstanceFactory = CreateInstance,
InvokeTypedTest = __InvokeTest_SecondTest,
};
metadata.UseRuntimeDataGeneration(testSessionId);
return new global::TUnit.Core.TestMetadata[] { metadata };
metadata_SecondTest.UseRuntimeDataGeneration(testSessionId);
return new global::TUnit.Core.TestMetadata[] { metadata_SecondTest };
}
public global::System.Collections.Generic.IEnumerable<global::TUnit.Core.TestDescriptor> EnumerateTestDescriptors()
{
Expand All @@ -65,10 +65,10 @@ internal sealed class TUnit_TestProject_AbstractTests_ConcreteClass2_SecondTest_
HasDataSource = false,
RepeatCount = 0,
DependsOn = global::System.Array.Empty<string>(),
Materializer = GetTests
Materializer = __Materialize_SecondTest
};
}
private static global::System.Attribute[] __CreateAttributes()
private static global::System.Attribute[] __CreateAttributes_0()
{
return
[
Expand All @@ -77,7 +77,7 @@ internal sealed class TUnit_TestProject_AbstractTests_ConcreteClass2_SecondTest_
new global::TUnit.Core.InheritsTestsAttribute()
];
}
private static global::System.Threading.Tasks.ValueTask __InvokeTest(global::TUnit.TestProject.AbstractTests.ConcreteClass2 instance, object?[] args, global::System.Threading.CancellationToken cancellationToken)
private static global::System.Threading.Tasks.ValueTask __InvokeTest_SecondTest(global::TUnit.TestProject.AbstractTests.ConcreteClass2 instance, object?[] args, global::System.Threading.CancellationToken cancellationToken)
{
try
{
Expand All @@ -89,28 +89,57 @@ internal sealed class TUnit_TestProject_AbstractTests_ConcreteClass2_SecondTest_
return new global::System.Threading.Tasks.ValueTask(global::System.Threading.Tasks.Task.FromException(ex));
}
}
}


// ===== FILE SEPARATOR =====

// <auto-generated/>
#pragma warning disable

#nullable enable
namespace TUnit.Generated;
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverageAttribute]
[global::System.CodeDom.Compiler.GeneratedCode("TUnit", "1.0.0.0")]
internal static class TUnit_TestProject_AbstractTests_ConcreteClass2__ClassHelper
{
private static global::System.Collections.Generic.IReadOnlyList<global::TUnit.Core.TestMetadata> __Materialize_SecondTest(string testSessionId)
{
var metadata = new global::TUnit.Core.TestMetadata<global::TUnit.TestProject.AbstractTests.ConcreteClass2>
{
TestName = "SecondTest",
TestClassType = typeof(global::TUnit.TestProject.AbstractTests.ConcreteClass2),
TestMethodName = "SecondTest",
Dependencies = global::System.Array.Empty<global::TUnit.Core.TestDependency>(),
AttributeFactory = __CreateAttributes_0,
DataSources = global::System.Array.Empty<global::TUnit.Core.IDataSourceAttribute>(),
ClassDataSources = global::System.Array.Empty<global::TUnit.Core.IDataSourceAttribute>(),
PropertyDataSources = global::System.Array.Empty<global::TUnit.Core.PropertyDataSource>(),
PropertyInjections = global::System.Array.Empty<global::TUnit.Core.PropertyInjectionData>(),
InheritanceDepth = 0,
FilePath = @"",
LineNumber = 11,
MethodMetadata = new global::TUnit.Core.MethodMetadata
{
Type = typeof(global::TUnit.TestProject.AbstractTests.ConcreteClass2),
TypeInfo = new global::TUnit.Core.ConcreteType(typeof(global::TUnit.TestProject.AbstractTests.ConcreteClass2)),
Name = "SecondTest",
GenericTypeCount = 0,
ReturnType = typeof(void),
ReturnTypeInfo = new global::TUnit.Core.ConcreteType(typeof(void)),
Parameters = global::System.Array.Empty<global::TUnit.Core.ParameterMetadata>(),
Class = global::TUnit.Core.ClassMetadata.GetOrAdd("TestsBase`1:global::TUnit.TestProject.AbstractTests.ConcreteClass2", new global::TUnit.Core.ClassMetadata
{
Type = typeof(global::TUnit.TestProject.AbstractTests.ConcreteClass2),
TypeInfo = new global::TUnit.Core.ConcreteType(typeof(global::TUnit.TestProject.AbstractTests.ConcreteClass2)),
Name = "ConcreteClass2",
Namespace = "TUnit.TestProject.AbstractTests",
Assembly = global::TUnit.Core.AssemblyMetadata.GetOrAdd("TestsBase`1", "TestsBase`1"),
Parameters = global::System.Array.Empty<global::TUnit.Core.ParameterMetadata>(),
Properties = global::System.Array.Empty<global::TUnit.Core.PropertyMetadata>(),
Parent = null
})
},
InstanceFactory = CreateInstance,
InvokeTypedTest = __InvokeTest_SecondTest,
};
metadata.UseRuntimeDataGeneration(testSessionId);
return new global::TUnit.Core.TestMetadata[] { metadata };
}
internal static global::TUnit.TestProject.AbstractTests.ConcreteClass2 CreateInstance(global::System.Type[] typeArgs, object?[] args)
{
return new global::TUnit.TestProject.AbstractTests.ConcreteClass2();
}
[global::System.Runtime.CompilerServices.ModuleInitializer]
internal static void Initialize()
{
global::TUnit.Core.SourceRegistrar.Register(typeof(global::TUnit.TestProject.AbstractTests.ConcreteClass2), new TUnit_TestProject_AbstractTests_ConcreteClass2_SecondTest_TestSource());
global::TUnit.Core.SourceRegistrar.Register(typeof(global::TUnit.TestProject.AbstractTests.ConcreteClass2), new TUnit_TestProject_AbstractTests_ConcreteClass2__TestSource());
}
}

Expand Down
Loading
Loading