Replace jquery-ujs with @hotwired/turbo#2448
Merged
nickcharlton merged 1 commit intomainfrom Feb 14, 2024
Merged
Conversation
seanpdoyle
force-pushed
the
turbo
branch
4 times, most recently
from
6b3c858 to
dd95787
Compare
seanpdoyle
force-pushed
the
stimulus
branch
2 times, most recently
from
3259381 to
c3074a0
Compare
nickcharlton
approved these changes
Dec 12, 2023
|
@seanpdoyle Thank you for doing this. What are your thoughts on replacing this |
mvz
reviewed
Jan 8, 2024
spec/example_app/app/views/admin/customers/_collection_item_actions.html.erb
Show resolved
Hide resolved
seanpdoyle
force-pushed
the
stimulus
branch
4 times, most recently
from
a78a5ca to
ee358f4
Compare
seanpdoyle
force-pushed
the
turbo
branch
3 times, most recently
from
09f2953 to
43da734
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
seanpdoyle
force-pushed
the
turbo
branch
2 times, most recently
from
965dc25 to
7a9ec8f
Compare
seanpdoyle
force-pushed
the
turbo
branch
2 times, most recently
from
19a2e6e to
66497ef
Compare
seanpdoyle
force-pushed
the
turbo
branch
5 times, most recently
from
f667fba to
bc718a1
Compare
nickcharlton
force-pushed
the
stimulus
branch
from
8e8dbb2 to
d38f8fa
Compare
Replace our client-side dependency on `jquery-ujs` with
[@hotwired/turbo][].
In addition to adding an entry to the `package.json` file, this commit
replaces `[data-confirm]` attributes with `[data-turbo-confirm]`, and
`[data-method]` attributes with `[data-turbo-method]`.
In an effort to minimize the diff, this commit *does not* replace the
`link_to` calls made with `method: :delete` with [button_to][] calls.
Ideally, they'd utilize `button_to` to render a `<form>` element for the
destructive action.
In the future, once that change is complete, the `data: {turbo_method:
:delete}` attributes can once again be passed as `method: :delete`
options.
[@hotwired/turbo]: https://turbo.hotwired.dev
[turbo-rails]: https://github.com/hotwired/turbo-rails
[link_to]: https://edgeapi.rubyonrails.org/classes/ActionView/Helpers/UrlHelper.html#method-i-link_to
[button_to]: https://edgeapi.rubyonrails.org/classes/ActionView/Helpers/UrlHelper.html#method-i-button_to
Member
|
Thanks again for keeping this up to date, @seanpdoyle! |
Contributor
Author
|
Thank you for pushing this forward! Just to highlight some troubles: this PR seems to introduce some test flakiness with regard to the search field. I'm not sure about the cause, since the #2447 PR was the one responsible for modifying how those test drive the search behavior. It's something to monitor in the future. |
Member
|
Ah, interesting, thanks! I'll keep an eye on it and open an issue if it keeps happening. I know on a certain client project we had some trouble with the way we're using to writing feature/system specs and test flakiness and I might need some help digging into it. |
floehopper
added a commit
to freerange/administrate-field-active_storage
that referenced
this pull request
May 10, 2025
This takes the same approach as in this `administrate` PR [1] by adding the `data-turbo-method` and `data-turbo-confirm` attributes supported by Hotwire Turbo [2,3] to the link for removing an attachment. The existing `method` option and `data-confirm` attribute are left in place to avoid breaking the behaviour under UJS [4] which was deprecated in Rails v7 and removed in Rails v7.2.A As the `administrate` PR says, ideally the `link_to` would be replaced by `button_to`. However, in the interests of making the change as small as possible and retaining consistency with `administrate` itself, it seems OK to keep the `link_to` in place. [1]: thoughtbot/administrate#2448 [2]: https://turbo.hotwired.dev/handbook/drive#performing-visits-with-a-different-method [3]: https://turbo.hotwired.dev/handbook/drive#requiring-confirmation-for-a-visit [4]: https://api.rubyonrails.org/v7.0/classes/ActionView/Helpers/UrlHelper.html#method-i-link_to-label-Deprecated-3A+Rails+UJS+Attributes
floehopper
added a commit
to freerange/administrate-field-active_storage
that referenced
this pull request
May 10, 2025
This takes the same approach as in this `administrate` PR [1] by adding the `data-turbo-method` and `data-turbo-confirm` attributes supported by Hotwire Turbo [2,3] to the link for removing an attachment. The existing `method` option and `data-confirm` attribute are left in place to avoid breaking the behaviour under UJS [4] which was deprecated in Rails v7 and removed in Rails v7.2. As the `administrate` PR says, ideally the `link_to` would be replaced by `button_to`. However, in the interests of making the change as small as possible and retaining consistency with `administrate` itself, it seems OK to keep the `link_to` in place. [1]: thoughtbot/administrate#2448 [2]: https://turbo.hotwired.dev/handbook/drive#performing-visits-with-a-different-method [3]: https://turbo.hotwired.dev/handbook/drive#requiring-confirmation-for-a-visit [4]: https://api.rubyonrails.org/v7.0/classes/ActionView/Helpers/UrlHelper.html#method-i-link_to-label-Deprecated-3A+Rails+UJS+Attributes
floehopper
added a commit
to freerange/administrate-field-active_storage
that referenced
this pull request
May 10, 2025
This takes the same approach as in this `administrate` PR [1] by adding the `data-turbo-method` and `data-turbo-confirm` attributes supported by Hotwire Turbo [2,3] to the link for removing an attachment. The existing `method` option and `data-confirm` attribute are left in place to avoid breaking the behaviour under UJS [4] which was deprecated in Rails v7 and removed in Rails v7.2. As the `administrate` PR says, ideally the `link_to` would be replaced by `button_to`. However, in the interests of making the change as small as possible and retaining consistency with `administrate` itself, it seems OK to keep the `link_to` in place. [1]: thoughtbot/administrate#2448 [2]: https://turbo.hotwired.dev/handbook/drive#performing-visits-with-a-different-method [3]: https://turbo.hotwired.dev/handbook/drive#requiring-confirmation-for-a-visit [4]: https://api.rubyonrails.org/v7.0/classes/ActionView/Helpers/UrlHelper.html#method-i-link_to-label-Deprecated-3A+Rails+UJS+Attributes
Dreamersoul
pushed a commit
to Dreamersoul/administrate-field-active_storage
that referenced
this pull request
May 11, 2025
This takes the same approach as in this `administrate` PR [1] by adding the `data-turbo-method` and `data-turbo-confirm` attributes supported by Hotwire Turbo [2,3] to the link for removing an attachment. The existing `method` option and `data-confirm` attribute are left in place to avoid breaking the behaviour under UJS [4] which was deprecated in Rails v7 and removed in Rails v7.2. As the `administrate` PR says, ideally the `link_to` would be replaced by `button_to`. However, in the interests of making the change as small as possible and retaining consistency with `administrate` itself, it seems OK to keep the `link_to` in place. [1]: thoughtbot/administrate#2448 [2]: https://turbo.hotwired.dev/handbook/drive#performing-visits-with-a-different-method [3]: https://turbo.hotwired.dev/handbook/drive#requiring-confirmation-for-a-visit [4]: https://api.rubyonrails.org/v7.0/classes/ActionView/Helpers/UrlHelper.html#method-i-link_to-label-Deprecated-3A+Rails+UJS+Attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace our client-side dependency on
jquery-ujswith@hotwired/turbo.
In addition to adding an entry to the
package.jsonfile, this commitreplaces
[data-confirm]attributes with[data-turbo-confirm], and[data-method]attributes with[data-turbo-method].In an effort to minimize the diff, this commit does not replace the
link_tocalls made withmethod: :deletewith button_to calls.Ideally, they'd utilize
button_toto render a<form>element for thedestructive action.
In the future, once that change is complete, the
data: {turbo_method: :delete}attributes can once again be passed asmethod: :deleteoptions.