Fix Become button on demo app#2787
Merged
nickcharlton merged 1 commit intothoughtbot:mainfrom Mar 17, 2025
Merged
Conversation
This stops the "become" button appearing on `HasMany` field items, which doesn't make any sense.
nickcharlton
force-pushed
the
fix-become-button
branch
from
cea7b3c to
fc367e4
Compare
Member
|
Thanks! |
nickcharlton
pushed a commit
that referenced
this pull request
Apr 7, 2025
In #2787, where this was originally fixed, it turns out that the condition wasn't evaluated correctly, so the table header wasn't being rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Become button appearing in
HasManyField oncustomers.showdemo app.Before:
After: