Skip to content

feat(design): redesign part 3#1142

Merged
cjroth merged 8 commits into
mainfrom
cjroth/redesign-2
Jul 25, 2026
Merged

feat(design): redesign part 3#1142
cjroth merged 8 commits into
mainfrom
cjroth/redesign-2

Conversation

@cjroth

@cjroth cjroth commented Jul 25, 2026

Copy link
Copy Markdown
Member

No description provided.

cjroth and others added 4 commits July 24, 2026 22:03
…I primitives

- Add vaul-based Drawer primitive and mobile card menus for touch-friendly actions
- Virtualize the sidebar chat list with virtua for smoother scrolling
- Extract shared page-create-action and chat-add-menu components
- Align responsive-modal, sheet, and searchable-menu styling with the redesign

Co-authored-by: Cursor <cursoragent@cursor.com>
- Cover Drawer, MobileCardMenu, PageCreateAction, and ChatAddMenu
- Refresh the SearchableMenu docs blurb after the blur-backdrop removal

Co-authored-by: Cursor <cursoragent@cursor.com>
- Restore main's version, oauth2-mock-server, and dev bundle ID (stale-branch reversions)
- Extract shared ResponsiveActionMenu; dedupe chat-add-menu and suggestion-chip
- Centralize the masked scrim (Scrim) and header control fill descendant class
- Share viewport test helpers in src/test-utils/viewport.ts; fix matchMedia leak
- Flush pending sidebar close resolvers on unmount so awaited navigation can't hang
- Fold the desktop border into ContentViewHeader; drop no-op vaul props
- Cover SearchableMenu's mobile drawer branch; drop its shared-module mock
- Fix stale JSDoc/comments and naming (isDesktopPanelOpen, New Skill casing)

Co-authored-by: Cursor <cursoragent@cursor.com>
- Add a force-desktop class and gate useIsMobile so the desktop app never
  falls into the mobile layout, and lower the min window width to 500px
- Pin the sidebar to the collapsed rail below 700px (toggles hide, stored
  preference survives), and hide the expand-only search affordance there
- Let the model selector's trigger label truncate in a narrow composer
- Bump the update notification card to the container radius tier

Co-authored-by: Cursor <cursoragent@cursor.com>
@cjroth
cjroth force-pushed the cjroth/redesign-2 branch from a749552 to 4f098d0 Compare July 25, 2026 02:04
@github-actions

Copy link
Copy Markdown

Semgrep Security Scan

No security issues found.

@cjroth cjroth changed the title Cjroth/redesign 2 feat(design): redesign pat 3 Jul 25, 2026
@cjroth cjroth changed the title feat(design): redesign pat 3 feat(design): redesign part 3 Jul 25, 2026
@github-actions

github-actions Bot commented Jul 25, 2026

Copy link
Copy Markdown

Preview environment destroyed 🧹

Stack preview-pr-1142 and its Cloudflare subdomain have been cleaned up.

@github-actions

github-actions Bot commented Jul 25, 2026

Copy link
Copy Markdown

PR Metrics

Metric Value
Lines changed (prod code) +1958 / -799
JS bundle size (gzipped) 🟡 538.3 KB → 571.8 KB (+33.5 KB, +6.2%)
Test coverage 🟢 79.54% → 80.33% (+0.8%)
Performance (preview) Preview not ready — Render deploy may have timed out
Accessibility
Best Practices
SEO

Updated Sat, 25 Jul 2026 03:10:52 GMT · run #2446

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔭 thunder-deep-review (advisory)

Reviewed the diff — no issues to report. ✅ Never approves, never requests changes, never gates merge.
head: 4f098d0d97a0 · mode: deep · deferred 0 item(s) already reported by other bots (best-effort dedup)

Replace the unmaintained Vaul dependency while preserving gesture behavior, styling, accessibility, and test coverage.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
- add ResponsivePopover primitive so menus stop hand-rolling the
  MobileCardMenu-vs-Popover split (chat skills bar, searchable menu)
- move the isMobile decision inside DetailPanelSurface instead of
  threading it through every settings page
- flatten repeated isMobile ternaries in chat-list and sidebar-footer

Co-authored-by: Cursor <cursoragent@cursor.com>
The redesign replaced the icon-only "Add custom agent" button with
PageCreateAction labeled "New Agent"; the spec still targeted the
old accessible name.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cjroth
cjroth merged commit efdeb0e into main Jul 25, 2026
31 checks passed
@cjroth
cjroth deleted the cjroth/redesign-2 branch July 25, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant