Add custom compare support for Table component #1362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
50
to
53
| export type TableCompreColumnMeta = { | ||
| identifier: number; | ||
| direction: TableSort; | ||
| }; |
There was a problem hiding this comment.
The type name TableCompreColumnMeta appears to contain a spelling error. Recommend renaming to TableCompareColumnMeta to accurately reflect its role in the comparison functionality.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Oksamies
force-pushed
the
02-28-add_custom_compare_support_for_table_component
branch
from
11b35b2 to
2f44122
Compare
Oksamies
deleted the
02-28-add_custom_compare_support_for_table_component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.