Skip to content

Address {ggplot2} 3.3.0 update #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2020
Merged

Conversation

echasnovski
Copy link
Collaborator

This PR deals with Travis build fails. The issue was a change in "outline.type" argument of geom_area() (see {ggplot2}'s 'NEWS.md') which affected shade_p_value() {vdiffr} test reference outputs. This PR updates those images directly (with vdiffr::manage_cases()) since there is no visible changes introduced. Note that in order to get clean tests locally, {ggplot2} version should be updated to 3.3.0.

Also:

  • {ggplot2} 3.3.0 introduced warnings in stat_function() which affected visualize(method = "theoretical") cases. Seems like it wasn't a necessary change (see this {ggplot2} issue). To remove these warnings, stat_function() was replaced to an equivalent geom_path(stat = "function").
  • I believe that {ggplot2} update should break {infer} CRAN checks pretty soon, so we should prepare for a soon {infer} CRAN update.

@echasnovski
Copy link
Collaborator Author

Oh, I forgot that {vdiffr} tests are disabled on CRAN, so no breaks will be there.
Nevertheless, I'll merge this because of the warnings (which are a compelling reason for a soon CRAN release).
@ismayc, @andrewpbray, @simonpcouch, please keep in mind that {ggplot2} 3.3.0 is now needed for passing tests.

@echasnovski echasnovski merged commit 1008b1c into develop Mar 8, 2020
@simonpcouch simonpcouch deleted the vdiffr-ggplot2-3.3.0-update branch March 10, 2020 06:20
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant