Report a bug of guide-bins: it cannot work with geom_sf.

[microly]

The guide-bins seems cannot work with geom_sf.

Some examples:

For geom_point, both "coloursteps" and "bins" guides work well:

library(ggplot2)
library(tibble)

ggplot(tibble(x = 1:10, y = x, z = x), aes(x, y, fill = z)) +
    geom_point(shape = 21, size = 10) +
    scale_fill_stepsn(guide = "coloursteps", colours = terrain.colors(10))

ggplot(tibble(x = 1:10, y = x, z = x), aes(x, y, fill = z)) +
    geom_point(shape = 21, size = 10) +
    scale_fill_stepsn(guide = "bins", colours = terrain.colors(10))

But, for geom_sf, only "coloursteps" can work.
There seems to be a bug in guide-bins.

nc <- sf::st_read(system.file("shape/nc.shp", package = "sf"))

ggplot() +
    geom_sf(aes(fill = AREA), data = nc) +
    scale_fill_stepsn(guide = "coloursteps", colours = terrain.colors(10))

ggplot() +
    geom_sf(aes(fill = AREA), data = nc) +
    scale_fill_stepsn(guide = "bins", colours = terrain.colors(10))

# Error in do.call("cbind", lapply(guide$geoms, function(g) g$data$size/10))[seq_len(n_keys),  : 
# subscript out of bounds

[yutannihilation]

Thanks, confirmed. The error occurs here when g$data doesn't contain size column. Probably it should be handled by the next if branch before getting subsetted?

ggplot2/R/guide-bins.R

Lines 321 to 327 in 6f5ffea

	key_size_mat <- do.call("cbind",
	lapply(guide$geoms, function(g) g$data$size / 10)
	)[seq_len(n_keys), , drop = FALSE]
	if (nrow(key_size_mat) == 0 || ncol(key_size_mat) == 0) {
	key_size_mat <- matrix(0, ncol = 1, nrow = n_keys)
	}

[microly]

OK, thanks for your work~

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/