-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Updated aes-calculated.r for pairlists #1155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated to correct code to handle formals of anonymous function and zero-length names
expr_ch <- as.character(expr) | ||
if (nchar(expr_ch) > 0) { | ||
as.name(gsub(match_calculated_aes, "\\1", as.character(expr))) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please match style?
Thanks. Can you please add a unit test or two and a bullet to NEWS? |
…onymous function s in `strip_dots`. Added bullet to NEWS.
I've added a unit test for a simple anonymous function to test-layer.r and a line to the bottom of the current NEWS. I've also shortened the line length of one of my updated lines by removing a redundant |
expr_ch <- as.character(expr) | ||
if (nchar(expr_ch) > 0) { | ||
as.name(gsub(match_calculated_aes, "\\1", expr_ch)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the style issue - }
should be on the same line as else
Sorry, normally put |
Thanks! |
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Updated to correct code to handle formals of anonymous function and zero-length names. This fixes the issue just posted at #1154 and discussed on Stack Overflow at http://stackoverflow.com/questions/31212054/functions-inside-aes .