Updates theme-defaults.r (#1555) #1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses issue tidyverse#1555 - elements added in new theme inherit "element_blank"
fixes tidyverse#1555)
| @@ -33,6 +33,8 @@ | |||
|
|
|||
| ## Bug fixes | |||
|
|
|||
| * All elements should now inherit correctly for all themes except theme_void(). (@Katiedaisey, #1555) | |||
There was a problem hiding this comment.
Would you mind alphabetising this under theme_void()
|
Should be fixed |
hadley
added a commit
that referenced
this pull request
Feb 24, 2016
Updates theme-defaults.r (#1555)
|
Thanks - much appreciated :). |
This was referenced Mar 10, 2016
thomasp85
added a commit
that referenced
this pull request
Sep 21, 2016
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses issue #1555 where some elements added under certain themes inherit "element_blank" and cannot be updated, e.g.
ggplot(mtcars, aes(wt, mpg)) + geom_point() + theme_classic() + theme(panel.grid.major.y = element_line(colour = "pink", size = 4))update explicitly declares parent element as necessary and children elements as element_blank