Fix geom_dotplot y limit calculations #1622
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 65.53%@@ master #1622 diff @@
========================================
Files 158 158
Lines 5546 5547 +1
Methods 0 0
Branches 0 0
========================================
+ Hits 3634 3635 +1
Misses 1912 1912
Partials 0 0
|
|
Do you think you could add a unit test too? |
|
Bump |
The computed y limits depend on both the group & panel. This ensures that the scale trainning does not get wrong (global y limits) input. Fixes tidyverse#1618
has2k1
force-pushed
the
fix-dotplot-ylimit
branch
from
6cb8dd9 to
424a014
Compare
|
Added tests. |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The computed y limits depend on both the group & panel.
This ensures that the scale trainning does not get wrong
(global y limits) input.
Fixes #1618