Change meaning of trim in geom_violin #1802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hadley @wch should this be the behaviour? df <- data.frame(a = c(1:100),b=c(rep(0,50),rep(1,50)))
ggplot(df,aes(y=a,x=factor(b))) + geom_violin(trim=TRUE)
ggplot(df,aes(y=a,x=factor(b))) + geom_violin(trim=FALSE)
no_range <- data.frame(x = factor(rep(1, 10)), y = rep(0, 10))
ggplot(no_range, aes(x, y)) + geom_violin(trim = TRUE)
ggplot(no_range, aes(x, y)) + geom_violin(trim = FALSE)
|
|
Looks good to me. |
|
@hadley ? |
|
LGTM |
schloerke
added a commit
to schloerke/ggplot2
that referenced
this pull request
Oct 6, 2016
* master: (30 commits) Elucidate & implement consistent principles for discrete NA Change meaning of trim (tidyverse#1802) Document strip.placement theme setting Style tweaks for theme() More sophisticated facet var evaluation strategy Teach rd_aesthetics about optional aesthetics Allow defintion of optional aes Link to geom_count from geom_point help Improve geom_density docs. Support hms position scales Correct aesthetic specs for bar charts Add check.aes and check.param args to layer() Handle sign transforming transformations Axis labels should always be character Only format numbers Update revdep email Re-run revdeps Run revdep check fix stacking (tidyverse#1817) Fix axis names for FacetNull (tidyverse#1814) ...
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1793
This PR changes the trim behaviour back to how it worked in v1.x.x