-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Make title, subtitle, caption and tag as labs()'s named arguments #2669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
clauswilke
merged 14 commits into
tidyverse:master
from
yutannihilation:labs-named-args
Aug 24, 2018
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
aa6a882
add tests for labs()
yutannihilation cbfd97f
make label params as the formal arguments of labs()
yutannihilation 83a51ed
respect missingness in ggtitle()
yutannihilation 4a1115f
improve description about labs()
yutannihilation 0ff44f4
use waive() to represent missingness in labs()
yutannihilation cc14ce4
fix a typo
yutannihilation 0c2008f
apply tidyverse style
yutannihilation 755ed17
Enable !!! in labs()
yutannihilation 7e181ad
Merge remote-tracking branch 'upstream/master' into labs-named-args
yutannihilation ccf014f
Add a news bullet
yutannihilation 65eda76
Merge remote-tracking branch 'upstream/master' into labs-named-args
yutannihilation 138474d
Add the Oxford comma
yutannihilation bff6b5e
Merge remote-tracking branch 'upstream/master' into labs-named-args
yutannihilation 273cb5f
Merge remote-tracking branch 'upstream/master' into labs-named-args
yutannihilation File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,24 @@ test_that("setting guide labels works", { | |
expect_identical(labs(colour = "my label")$colour, "my label") | ||
# American spelling | ||
expect_identical(labs(color = "my label")$colour, "my label") | ||
|
||
# No extra elements exists | ||
expect_equivalent(labs(title = "my title"), list(title = "my title")) # formal argument | ||
expect_equivalent(labs(colour = "my label"), list(colour = "my label")) # dot | ||
expect_equivalent(labs(foo = "bar"), list(foo = "bar")) # non-existent param | ||
|
||
# labs() can take a list as the first argument | ||
expect_identical(labs(list(title = "my title", tag = "A)"))$tag, "A)") | ||
|
||
# NULL is preserved | ||
expect_equivalent(labs(title = NULL), list(title = NULL)) | ||
|
||
# ggtitle works in the same way as labs() | ||
expect_identical(ggtitle("my title")$title, "my title") | ||
expect_identical(ggtitle("my title", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you please use tidyverse style here? http://style.tidyverse.org/syntax.html#long-lines |
||
subtitle = "my subtitle")$subtitle, "my subtitle") | ||
expect_equivalent(ggtitle("my title", subtitle = NULL), | ||
list(title = "my title", subtitle = NULL)) | ||
}) | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, why should
labs()
accept a list as its first argument?I couldn't find this is documented or used elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that ggplot2 uses tidy eval, I think we should remove this, and in the previous line use
rlang::list2()
instead oflist()
. That way you can use!!!
if you do already have a list of labels.