Skip to content

Fix #2839: 'continuous_scale' palette param docs #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2018

Conversation

brodieG
Copy link
Contributor

@brodieG brodieG commented Aug 18, 2018

The 'palette' parameter has different usage in continuous
vs discrete scales, and the documentation described the
discrete usage.

The 'palette' parameter has different usage in continuous
vs discrete scales, and the documentation described the
discrete usage.
@hadley
Copy link
Member

hadley commented Aug 20, 2018

Could you please re-roxygenise?

@brodieG
Copy link
Contributor Author

brodieG commented Aug 20, 2018

Will do this evening; I didn't b/c I noticed there were many other docs that were not re-roxygenized and I figured you all did this at the end. Unless I hear otherwise I will only commit the md files this affects directly.

@clauswilke
Copy link
Member

Out-of-date .Rds should be fixed since #2833.

@brodieG
Copy link
Contributor Author

brodieG commented Aug 21, 2018

Should be ready for review now. There were still a few other unrendered mds that I left out of this PR (to clarify: mds that were modified by roxygen edits not in this PR).

@clauswilke clauswilke merged commit 5a37ae7 into tidyverse:master Aug 22, 2018
@clauswilke
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Feb 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants