-
Notifications
You must be signed in to change notification settings - Fork 2.1k
add length argument to geom_rug to allow different lengths #3109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yutannihilation
merged 17 commits into
tidyverse:master
from
daniel-wells:geom-rug-length
Mar 4, 2019
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
de51017
add length argument to geom_rug to allow different lengths
daniel-wells c861d83
add PR number
daniel-wells 7c7db06
use spaces not tabs
daniel-wells 9caa182
move length unit specification to function parameter level
daniel-wells 017b5ed
test that geom_rug length parameter needs unit object
daniel-wells f14492f
Merge branch 'master' into geom-rug-length
daniel-wells 1f9c124
update geom_rug example with unit length
daniel-wells 628db16
update geom_rug documentation
daniel-wells 8f952f5
add spaces for tidyverse style
daniel-wells e8919eb
use code quotes
daniel-wells f867694
use inherits for S3 class check
daniel-wells 4ddc907
use call. = F
daniel-wells 9149838
add geom_rug tests for actual lengths of grob
daniel-wells da35c26
remove unnecessary test
daniel-wells ec86925
add explanation of rug length default
daniel-wells 05237a8
add new parameters last with default value
daniel-wells 0544d57
escape %
daniel-wells File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the deleted lines 7-9 contain important information and should be kept. But edit so it's clear that the default size can be modified.
Example: