-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Document flipped computed variables #4128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document flipped computed variables #4128
Conversation
Added this sentence. Does this sound good?
|
I think this is fine. Maybe put the "or" in italics just as is the case for the aesthetics. |
The "or" between computed variables, I mean. |
Makes sense, I put them in Italic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh, this was merged already. Looks like my browser had cached an old version. |
Fix #4124
These four stat have variables whose names differ depending on the orientation.
stat_boxplot()
:middle
,lower
, andupper
. This feels a bit tricky at least in two points; the flipped names are asynmetric (e.g.middle
vsxmiddle
, notymiddle
vsxmiddle
), andnotchlower
andnotchupper
doesn't have their flipped form.stat_smooth()
:y
,ymin
, andymax
stat_function()
: these generate bothstat_ecdf()
x
andy
, so the documentation would be cryptic like below, so I don't address them in this pull request (at least they don't have undocumented computed variables)edit: I just remembered
stat_ecdf()
doesn't support flipping (c.f. #4005)