Skip to content

Fix failures on test coverage CI #4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yutannihilation
Copy link
Member

(Fix #4446 (comment))

Tests in tests/testthat/test-prohibited-functions.R needs to parse R files to do static analysis. But, files are not always available, so this test might fail and covr::coverage() is the case.

test_that("list up R files properly", {
expect_true(length(R_files) > 0)
})

This pull requests let the test skip on covr::coverage(), and also on CRAN for safety.

@thomasp85 thomasp85 merged commit 344765f into tidyverse:master Apr 28, 2021
@thomasp85
Copy link
Member

Thanks!

@yutannihilation yutannihilation deleted the ci/disable-failing-tests-on-covr branch April 28, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants