Convert size = NA to 0 before rendering guide_legend #4672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paleolimbot
approved these changes
Nov 16, 2021
| @@ -278,6 +278,10 @@ guide_geom.legend <- function(guide, layers, default_mapping) { | |||
| # override.aes in guide_legend manually changes the geom | |||
| data <- modify_list(data, guide$override.aes) | |||
|
|
|||
| if (!is.null(data$size)) { | |||
There was a problem hiding this comment.
I forget if data is a data.frame here, but if it is, I wonder of "size" %in% names(data) is a bit better (lest data ever become a tibble)
There was a problem hiding this comment.
We have this pattern all over the place so once we begin to accept tibbles inside the code we will have a lot of places to fix up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4559
This is a simple fix that converts all instances of
NAin the size aesthetic to0