Skip to content

Fixes #4399 fullrange documentation #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fixes #4399 fullrange documentation #4822

wants to merge 4 commits into from

Conversation

thoolihan
Copy link
Contributor

Fixes #4399: Provides clearer documentation for fullrange parameter of geom_smooth(), explaining that when TRUE, the smoothing line spans the plot area potentially beyond data, but not including padding created by expansion. NEWS.md updated included.

This is my first commit/pull request for ggplot2. I reviewed contributing, wiki, and ggplot2 website guidelines. Please let me know if I have missed anything.

Provides clearer documentation for fullrange parameter of geom_smooth(), explaining that when TRUE, the smoothing line spans the plot area potentially beyond data, but not including padding created by expansion.
NEWS.md change for #4399 documentation change clarifying effect of fullrange parameter of geom_smooth.
Fix spelling of parameter
@yutannihilation
Copy link
Member

Thanks. As you might notice when you edit the file, you need to make the changes to the original file, not the generated docs (and then run devtools::document()).

% Generated by roxygen2: do not edit by hand
% Please edit documentation in R/geom-smooth.r, R/stat-smooth.r

@thoolihan
Copy link
Contributor Author

Did not pass tests, will close, fix, and resubmit.

@thoolihan thoolihan closed this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify that fullrange = TRUE extends range to the axis limits, not the whole plot.
2 participants