Skip to content

Do not mention soft-deprecated aes_() #4913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yutannihilation
Copy link
Member

Since aes_() is already soft-deprecated, let's not mention it in the doc. This pull request also update the version of roxgen2 to 7.2.1.

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I can't see how any of the failing tests are related to this PR

@yutannihilation
Copy link
Member Author

As this change a lot of docs, I'm a bit afraid this will cause some conflicts on other pull requests. But, I need to merge this sooner or later anyway, so let's do now...

@yutannihilation yutannihilation merged commit c8f01c0 into tidyverse:main Jul 26, 2022
@yutannihilation yutannihilation deleted the doc/do-not-mention-aes_ branch July 26, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants