add param to alter width of rug segments in geom_rug #662
Conversation
| @@ -16,20 +19,20 @@ | |||
| #' p + geom_point() + geom_rug(sides="trbl") # All four sides | |||
| #' p + geom_point() + geom_rug(position='jitter') | |||
| geom_rug <- function (mapping = NULL, data = NULL, stat = "identity", position = "identity", sides = "bl", ...) { | |||
There was a problem hiding this comment.
rugwidth should be here, in the definition for geom_rug, instead of in GeomRug$new.
There was a problem hiding this comment.
So it doesn't need to appear in both locations? rugwidth will be passed to GeomRug$draw in the triple-dots, and there is no need for a default? I was going off how geom_boxplot was written.
There was a problem hiding this comment.
It should be something like:
geom_rug <- function (mapping = NULL, data = NULL, stat = "identity", position = "identity", sides = "bl", rugwidth = 0.03, ...) {
GeomRug$new(mapping = mapping, data = data, stat = stat, position = position, sides = sides, rugwidth = rugwidth, ...)
}
| @@ -15,21 +18,21 @@ | |||
| #' p + geom_point() + geom_rug(sides="b") # Rug on bottom only | |||
| #' p + geom_point() + geom_rug(sides="trbl") # All four sides | |||
| #' p + geom_point() + geom_rug(position='jitter') | |||
| geom_rug <- function (mapping = NULL, data = NULL, stat = "identity", position = "identity", sides = "bl", ...) { | |||
| GeomRug$new(mapping = mapping, data = data, stat = stat, position = position, sides = sides, ...) | |||
| geom_rug <- function (mapping = NULL, data = NULL, stat = "identity", position = "identity", sides = "bl", rugwidth=0.03 ...) { | |||
There was a problem hiding this comment.
okay, fixed now. Wow, i'm sorry. That original line was really sloppy of me.
|
It might be better if it would accept a unit object, so that the length could be specified in absolute or relative lengths. The default could still be Also, for future reference: there are a lot of spurious whitespace changes in the diff - better not to have those. |
|
Good idea. I'll change it to units(). Sorry about the whitespace. I have my text editor set to kill all trailing whitespace. I'll make sure that those whitespace changes don't happen again. |
|
Okay, I now have rugwidth accepting units arguments. How do you think it should handle the case, if the user does not pass it a unit object? |
|
I think it should only work with unit objects. There are other places where unit objects are required... |
|
So should I check that rugwith has class unit, and stop if it is not? Or try to coerce the argument into a unit object? |
|
I think that it would be good to check that it's a unit, and give an error if it's not. |
|
I added a check on the class of the |
|
Looks good! Just FYI, it'll probably be a while before this is merged, since the next release, 0.9.3, will be bugfixes. After that, ggplot2 will be converted from proto to S3, and I think that will be the time to add features like this. |
|
no problem; I'm in no rush. I had noticed this while tweaking the geom to produce Tufte's range frames, and thought it would be a good idea to push it upstream. |
|
Could you please rebase/merge against master, re-document with the development version of roxygen2 ( |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
I noticed that the width of the segments in geom_rug was hardcoded as 0.03. I added a parameter to allow the user to change it. But, I'm not sure that is the most idiomatic way to do it. Perhaps it should just use the width aes.