One limit #908
One limit #908
Conversation
|
Thanks! You can be the first to try out my new PR checklist: Can you please :
|
|
I added info in news and updated some documentation. I am not sure this needs a graphic example, but if you think it should have one I can create one. |
| @@ -7,6 +7,11 @@ ggplot2 0.9.3.1.99 | |||
| * `ggpcp()`, `ggfluctuation()`, `ggmissing()`, `ggstructure()`, and | |||
| `ggorder()` are now defunct and have been removed. | |||
|
|
|||
| MINOR FEATURES | |||
There was a problem hiding this comment.
Can you remove this heading and put your news item at the top?
|
Not sure if you get notified if I just add a commit so I wanted to comment and let you know I fixed the news issue you mentioned. |
|
Thanks (I'm not). It looks good to go - can you please rebase/merge (probably just a conflict from NEWS) and then I'll accept. |
Implements setting of only one limit of a continuous scale by specifying NA for the limit which you don't want to set.
|
Done, let me know if everything looks good! |
|
Looks like https://travis-ci.org/hadley/ggplot2/builds/19600088 failed - can you take a look please? |
The range of mtcars wt data is from 1.513 to 5.424, so the previous example was causing an error because there were no points to obtain a range from.
|
The error was occurring because the lower bound in the example was excluding all the points in the dataset so there was no way to calculate the upper bound. I fixed the example, I don't know if we should do something to address this error however... |
|
I'd be happy to accept a pull request that gave a better error message in that case :) |
|
@jimhester How difficult do you think it is to implement this for the x/ylim for coord_cartesian? I'm no R expert and want to know whether its worth the trouble digging into it. |
|
@cmorty It is definitely possible and would be useful. As to how hard it would be to implement it should be a fairly small change once you find the proper place to make the change. Finding that place might be challenging however, I would start with trying it out, when it errors use |
|
@cmorty Similarly for |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
This is a up to date rebase of #684, it addresses issue #557.