Skip to content

add "none" to documentation of theme() for parameter legend.position #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2014
Merged

add "none" to documentation of theme() for parameter legend.position #918

merged 3 commits into from
Feb 25, 2014

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 25, 2014

Reissue of #831.

@hadley
Copy link
Member

hadley commented Feb 25, 2014

  • Motivate the change in one paragraph, and include if affects code,
    include it in NEWS. In parenthesis, reference your github user name and
    the issue, (@hadley, #1234)
  • Check pull request only includes relevant changes.
  • Use the official style.
  • Update documentation and re-run roxygen2

You don't need to change the NEWS here, but generally I think it's only worthwhile to list major documentation changes.

hadley added a commit that referenced this pull request Feb 25, 2014
add "none" to documentation of theme() for parameter legend.position
@hadley hadley merged commit 8bbeef3 into tidyverse:master Feb 25, 2014
@krlmlr krlmlr deleted the legend-position-doc-2 branch February 25, 2014 15:20
@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants