New theme option to put panel/grid on top of data #993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -423,7 +426,7 @@ add_theme <- function(t1, t2, t2name) { | |||
| # If x is NULL or element_blank, then just assign it y | |||
| x <- y | |||
| } else if (is.null(y) || is.character(y) || is.numeric(y) || | |||
| inherits(y, "element_blank")) { | |||
| is.logical(y) || inherits(y, "element_blank")) { | |||
|
Looks good. Could you please
|
Merge remote-tracking branch 'hadley/master' into feature/panel_on_top Conflicts: man/theme.Rd
hadley
added a commit
that referenced
this pull request
Jun 18, 2015
New theme option to put panel/grid on top of data
|
Thanks! |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new theme option,
panel.ontop, places the background objects (panel, gridlines), on top of thedata in the plot if set to
TRUE. This allows one to place gridlines over the data. One would typically also include a blank or transparent panel in the theme.This is implemented by changes in facet_panels.* functions, changing the ordering of layers depending on the value of
theme$panel.ontop.add_themewas also changed to allow for logical theme elements.This is a simple implementation. A more advanced one would allow gridlines to be placed on top of data while keeping the panel below data.
Updated
theme()documentation included via roxygen 4.0.1.Tests passed with the following exception. which I believe is unrelated:
Fixes #551