Skip to content

styling with styler #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2018
Merged

styling with styler #392

merged 1 commit into from
Jan 6, 2018

Conversation

lorenzwalthert
Copy link
Contributor

conservative styling with scope = "spaces" and strict = FALSE.

@lorenzwalthert
Copy link
Contributor Author

Reference: krlmlr#1
cc: @krlmlr

@hadley hadley merged commit 5bd376e into tidyverse:master Jan 6, 2018
@hadley
Copy link
Member

hadley commented Jan 6, 2018

Thanks!

@lorenzwalthert lorenzwalthert deleted the f-styler branch January 6, 2018 14:14
@lorenzwalthert
Copy link
Contributor Author

Should we do a follow-up with scope > "spaces"?

@hadley
Copy link
Member

hadley commented Jan 6, 2018

Yeah, let's take a look. Does styler have the ability to ignore tribble() spacing yet?

@lorenzwalthert
Copy link
Contributor Author

Ok, cool. No, it has not. Maybe we should add that. We can use strict = FALSE, which just ensures at least one space around certain operators. That should leave many tribble calls untouched.

@lorenzwalthert
Copy link
Contributor Author

lorenzwalthert commented Jan 6, 2018

I opened r-lib/styler#317 to discuss that further (and labeled it with Status: Postponed and closed it for now because me and @krlmlr don't really have time to work on it now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants