docs/sdks/s3/js: move examples into separate files #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (4)
- docs/sdks/s3/aws-go-sdk.mdx: Language not supported
- docs/sdks/s3/aws-js-sdk.mdx: Language not supported
- examples/js/.gitignore: Language not supported
- examples/js/package.json: Language not supported
Comments suppressed due to low confidence (2)
examples/js/presigned-urls.js:9
- [nitpick] The variable name 'S3' is ambiguous. It should be renamed to 's3Client' for better readability.
const S3 = new S3Client({ region: "auto" });
examples/js/getting-started.js:60
- [nitpick] The variable name 'objects' is reused within the forEach loop, which can be confusing. Consider renaming it to 'objectPage' or something more descriptive.
objects.forEach((objects, pageNum) => {
katieschilling
previously approved these changes
Feb 4, 2025
The examples have also been amended to explain themselves better and have all been tested to ensure they work.
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (4)
- docs/sdks/s3/aws-go-sdk.mdx: Language not supported
- docs/sdks/s3/aws-js-sdk.mdx: Language not supported
- examples/js/.gitignore: Language not supported
- examples/js/package.json: Language not supported
Comments suppressed due to low confidence (2)
examples/js/getting-started.js:60
- [nitpick] The variable name 'objects' inside the forEach loop is ambiguous. It should be renamed to 'objectKeys' to avoid confusion.
objects.forEach((objects, pageNum) => {
examples/js/presigned-urls.js:31
- [nitpick] Add a comment explaining the purpose of the DeleteObjectCommand for consistency with the other commands.
// Presigned DELETE, allows users to delete objects.
katieschilling
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes TIG-3480
The examples have also been amended to explain themselves better and have all been tested to ensure they work.