-
Notifications
You must be signed in to change notification settings - Fork 5
docs(sdks/s3): fix Fly endpoints to use fly.storage.tigris.dev instead of t3.storage.dev #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Xe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Summary
This PR corrects a critical documentation error that was directing Fly.io users to the wrong Tigris endpoint. The changes systematically update all 9 S3 SDK documentation files to use the correct fly.storage.tigris.dev endpoint for requests made from within Fly.io environments, while preserving the correct t3.storage.dev endpoint for external requests.
- Impact: Fixes performance issues for Fly.io users by ensuring proper request routing
- Scope: Documentation-only changes across 9 SDK guides (CLI, Elixir, Go, Java, JavaScript, .NET, PHP, Python, Ruby)
- Consistency: All files follow the same pattern of correcting "within Fly" endpoint references
- Accuracy: Changes align with the issue description and properly address the routing problem introduced in commit b28eba1
Confidence Score: 5/5
- This PR is completely safe to merge with no risk
- Maximum confidence due to documentation-only changes that fix a clear error with consistent implementation across all files. No code execution risk, no breaking changes, and directly addresses the identified issue.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| docs/sdks/s3/aws-cli.md | 5/5 | Updated Fly.io endpoint from t3.storage.dev to fly.storage.tigris.dev in documentation and examples |
| docs/sdks/s3/aws-elixir-sdk.mdx | 5/5 | Corrected Fly.io endpoint URL in endpoint selection guidance |
| docs/sdks/s3/aws-go-sdk.mdx | 5/5 | Fixed Fly.io endpoint reference in SDK configuration instructions |
| docs/sdks/s3/aws-java-sdk.md | 5/5 | Updated Fly.io endpoint URL in Java SDK documentation |
| docs/sdks/s3/aws-js-sdk.mdx | 5/5 | Corrected Fly.io endpoint in JavaScript SDK endpoint configuration |
| docs/sdks/s3/aws-net-sdk.mdx | 5/5 | Fixed Fly.io endpoint URLs in two separate locations within .NET SDK documentation |
| docs/sdks/s3/aws-php-sdk.md | 5/5 | Updated Fly.io endpoint reference in PHP SDK endpoint configuration guide |
| docs/sdks/s3/aws-python-sdk.mdx | 5/5 | Corrected Fly.io endpoint URL in Python SDK configuration instructions |
| docs/sdks/s3/aws-ruby-sdk.mdx | 5/5 | Fixed Fly.io endpoint URLs in two separate sections of Ruby SDK documentation |
Sequence Diagram
sequenceDiagram
participant Developer as Developer
participant Docs as SDK Documentation
participant Code as Application Code
participant Fly as Fly.io Environment
participant T3 as t3.storage.dev
participant FlyEndpoint as fly.storage.tigris.dev
Developer->>Docs: Read SDK configuration guide
alt Before this PR (incorrect)
Docs-->>Developer: Use t3.storage.dev for all requests
Developer->>Code: Configure endpoint: t3.storage.dev
Code->>Fly: Deploy application to Fly.io
Fly->>T3: Make S3 request to t3.storage.dev
Note over Fly,T3: ❌ Incorrect routing - slower response
T3-->>Fly: Response (suboptimal performance)
else After this PR (correct)
Docs-->>Developer: Use fly.storage.tigris.dev when inside Fly
Developer->>Code: Configure endpoint: fly.storage.tigris.dev
Code->>Fly: Deploy application to Fly.io
Fly->>FlyEndpoint: Make S3 request to fly.storage.tigris.dev
Note over Fly,FlyEndpoint: ✅ Optimized routing - faster response
FlyEndpoint-->>Fly: Response (optimized performance)
end
9 files reviewed, no comments
Signed-off-by: Xe Iaso <[email protected]>
Fixes incorrect endpoint URLs in S3 SDK documentation that were directing Fly users to the wrong endpoint.
Problem
In commit b28eba1, changes were made to the S3 SDK documentation that errantly pointed Fly users to
t3.storage.devinstead offly.storage.tigris.devfor requests made from within Fly.Solution
Updated all 9 S3 SDK documentation files to correctly differentiate between:
https://t3.storage.devhttps://fly.storage.tigris.devFiles Changed
docs/sdks/s3/aws-cli.mddocs/sdks/s3/aws-elixir-sdk.mdxdocs/sdks/s3/aws-go-sdk.mdxdocs/sdks/s3/aws-java-sdk.mddocs/sdks/s3/aws-js-sdk.mdxdocs/sdks/s3/aws-net-sdk.mdxdocs/sdks/s3/aws-php-sdk.mddocs/sdks/s3/aws-python-sdk.mdxdocs/sdks/s3/aws-ruby-sdk.mdxExample Change
Before:
After:
Closes TIG-6005
Made-with-help-from: GitHub Copilot
Fixes #276
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.