Skip to content

affinity: refactor and address comments #10050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 3 commits into from
Dec 11, 2025
Merged

affinity: refactor and address comments #10050

ti-chi-bot merged 3 commits into from
Dec 11, 2025

Conversation

@lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Dec 11, 2025

What problem does this PR solve?

Issue Number: Close #9764

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024
affinity: address comments
7d1be03 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2025
@lhy1024 lhy1024 changed the title affinity: address comments affinity: refactor and address comments Dec 11, 2025
@lhy1024
refactor affinityManager.AllowSplit
2917a18 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2025
@lhy1024 lhy1024 mentioned this pull request Dec 11, 2025
Open
28 tasks
@lhy1024 lhy1024 requested a review from rleungx December 11, 2025 11:16
@lhy1024
fix test
db57a75 
Signed-off-by: lhy1024 <admin@liudos.us>
@codecov
Copy link

codecov bot commented Dec 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 82.35294% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.43%. Comparing base (27c2705) to head (db57a75).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10050      +/-   ##
==========================================
+ Coverage   78.40%   78.43%   +0.03%     
==========================================
  Files         511      512       +1     
  Lines       68415    68520     +105     
==========================================
+ Hits        53644    53747     +103     
- Misses      10876    10877       +1     
- Partials     3895     3896       +1
Flag Coverage Δ
unittests 78.43% <82.35%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rleungx
rleungx reviewed Dec 11, 2025
View reviewed changes
pkg/schedule/affinity/group.go
Comment on lines +111 to +114
// RegularSchedulingAllowed indicates whether balance scheduling is allowed.
RegularSchedulingAllowed bool `json:"-"`
// AffinitySchedulingAllowed indicates whether affinity scheduling is allowed.
AffinitySchedulingAllowed bool `json:"-"`
Copy link
Member

@rleungx rleungx Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is RegularSchedulingAllowed == !AffinitySchedulingAllowed?

Copy link
Contributor Author

@lhy1024 lhy1024 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, if the group is in degraded, they are both false.

rleungx
rleungx approved these changes Dec 11, 2025
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 11, 2025
@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 11, 2025

/retest

1 similar comment
@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 11, 2025

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 11, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HunDunDM, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 11, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-11 12:24:15.523213604 +0000 UTC m=+1130200.336991176: ☑️ agreed by rleungx.
  • 2025-12-11 13:04:02.440540889 +0000 UTC m=+1132587.254318471: ☑️ agreed by HunDunDM.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 11, 2025

/test pull-integration-realcluster-test

@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 11, 2025

This PR consists entirely of refactored code with no changes to the logic, except for these few lines.
{2CAF8E85-1E76-4A9F-80AE-2E386C60ADA4}

@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 11, 2025

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot bot merged commit aef91a5 into tikv:master Dec 11, 2025
31 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 11, 2025
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#10050
02df58d 
close tikv#9764

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 11, 2025
Closed
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 11, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #10051.
But this PR has conflicts, please resolve them!

HunDunDM pushed a commit to HunDunDM/pd that referenced this pull request Dec 11, 2025
@lhy1024 @HunDunDM
affinity: refactor and address comments (tikv#10050)
0b530ef 
close tikv#9764

Signed-off-by: lhy1024 <admin@liudos.us>
lhy1024 added a commit to lhy1024/pd that referenced this pull request Dec 14, 2025
@lhy1024
affinity: refactor and address comments (tikv#10050)
67071e0 
close tikv#9764

Signed-off-by: lhy1024 <admin@liudos.us>
lhy1024 added a commit to lhy1024/pd that referenced this pull request Dec 16, 2025
@lhy1024
affinity: refactor and address comments (tikv#10050)
bce31b7 
close tikv#9764

Signed-off-by: lhy1024 <admin@liudos.us>
lhy1024 added a commit to lhy1024/pd that referenced this pull request Dec 16, 2025
@lhy1024
affinity: refactor and address comments (tikv#10050)
535ef70 
close tikv#9764

Signed-off-by: lhy1024 <admin@liudos.us>
lhy1024 added a commit to lhy1024/pd that referenced this pull request Dec 16, 2025
@lhy1024
affinity: refactor and address comments (tikv#10050)
71658cf 
close tikv#9764

Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 mentioned this pull request Dec 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HunDunDM HunDunDM HunDunDM approved these changes

@rleungx rleungx rleungx approved these changes

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support data affinity schedule for performance optimization

4 participants

@lhy1024 @ti-chi-bot @HunDunDM @rleungx