Skip to content

Conversation

@JmPotato
Copy link
Member

@JmPotato JmPotato commented Feb 4, 2026

What problem does this PR solve?

Issue Number: Close #10210.

What is changed and how does it work?

Update `go.mod` files for the main project, client, tools, and integration tests to target Go `1.25.6` for consistent builds and tooling.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Summary by CodeRabbit

  • Chores
    • Upgraded Go toolchain to version 1.25.6 across build environments.

Signed-off-by: JmPotato <github@ipotato.me>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 4, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

The pull request updates the Go toolchain version from 1.25.5 to 1.25.6 across all go.mod files in the project: the root module, client, tests/integrations, and tools directories. No dependencies, replace directives, or functionality are affected.

Changes

Cohort / File(s) Summary
Go Toolchain Version Bump
go.mod, client/go.mod, tests/integrations/go.mod, tools/go.mod
Updated Go toolchain version directive from 1.25.5 to 1.25.6 across all module files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hoppy news! Go 1.25.6 hops in,
Four modules bump their toolchain skin,
Patch by patch, we stay current and spry,
No breaking changes, just patches on high! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating Go version to 1.25.6 across multiple modules. It is specific, directly related to the changeset, and follows good naming conventions.
Description check ✅ Passed The PR description includes the required Issue Number linking to #10210, a detailed commit message explaining the changes, and appropriate test checkboxes. All critical sections are completed.
Linked Issues check ✅ Passed The PR successfully addresses the objective from Issue #10210 by updating Go toolchain versions from 1.25.5 to 1.25.6 across all four go.mod files (main, client, tools, and tests).
Out of Scope Changes check ✅ Passed All changes are narrowly scoped to updating Go version directives in go.mod files. No unrelated changes, dependency modifications, or other out-of-scope alterations are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 4, 2026
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.70%. Comparing base (92e0ed9) to head (fade74f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10211   +/-   ##
=======================================
  Coverage   78.69%   78.70%           
=======================================
  Files         520      520           
  Lines       70089    70089           
=======================================
+ Hits        55158    55161    +3     
- Misses      10957    10960    +3     
+ Partials     3974     3968    -6     
Flag Coverage Δ
unittests 78.70% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 4, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, disksing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,disksing]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 4, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-04 06:08:17.212950176 +0000 UTC m=+247168.314348898: ☑️ agreed by disksing.
  • 2026-02-04 06:30:23.708905166 +0000 UTC m=+248494.810304192: ☑️ agreed by bufferflies.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Feb 4, 2026

/retest

4 similar comments
@JmPotato
Copy link
Member Author

JmPotato commented Feb 4, 2026

/retest

@JmPotato
Copy link
Member Author

JmPotato commented Feb 4, 2026

/retest

@JmPotato
Copy link
Member Author

JmPotato commented Feb 4, 2026

/retest

@JmPotato
Copy link
Member Author

JmPotato commented Feb 4, 2026

/retest

@JmPotato
Copy link
Member Author

JmPotato commented Feb 4, 2026

/test pull-unit-test-next-gen-3

@JmPotato
Copy link
Member Author

JmPotato commented Feb 5, 2026

/retest

@ti-chi-bot ti-chi-bot bot merged commit a1f2017 into tikv:master Feb 5, 2026
33 checks passed
@JmPotato JmPotato deleted the update_golang branch February 5, 2026 08:54
@JmPotato
Copy link
Member Author

JmPotato commented Feb 5, 2026

/cherry-pick release-nextgen-20251011

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 5, 2026
close tikv#10210

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@JmPotato: new pull request created to branch release-nextgen-20251011: #10222.
But this PR has conflicts, please resolve them!

Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

JmPotato added a commit to ti-chi-bot/pd that referenced this pull request Feb 6, 2026
close tikv#10210

Update `go.mod` files for the main project, client, tools, and integration tests to target Go `1.25.6` for consistent builds and tooling.

Signed-off-by: JmPotato <github@ipotato.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump patch version of Golang to 1.25.6

5 participants