Skip to content

Conversation

@JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #9296.

What is changed and how does it work?

- Implement dual-path storage for backward compatibility with legacy paths.
- Add new keypath formats for keyspace-specific resource group settings and states.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato requested review from okJiang and rleungx May 15, 2025 07:57
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2025
@JmPotato JmPotato force-pushed the keyspace_rg branch 4 times, most recently from 1b7c5af to 3fcce4b Compare May 16, 2025 02:57
@JmPotato JmPotato requested a review from lhy1024 May 16, 2025 03:08
JmPotato added 3 commits May 16, 2025 12:02
Signed-off-by: JmPotato <github@ipotato.me>
Signed-off-by: JmPotato <github@ipotato.me>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2025
Signed-off-by: JmPotato <github@ipotato.me>
Signed-off-by: JmPotato <github@ipotato.me>
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

Signed-off-by: JmPotato <github@ipotato.me>
@JmPotato JmPotato requested review from okJiang and rleungx May 16, 2025 10:49
@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 73.75000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 76.02%. Comparing base (04f1ae0) to head (ce689cf).
Report is 3 commits behind head on master.

❌ Your patch status has failed because the patch coverage (73.75%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9327      +/-   ##
==========================================
+ Coverage   75.98%   76.02%   +0.04%     
==========================================
  Files         473      473              
  Lines       73625    73683      +58     
==========================================
+ Hits        55945    56020      +75     
+ Misses      14181    14162      -19     
- Partials     3499     3501       +2     
Flag Coverage Δ
unittests 76.02% <73.75%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 19, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 19, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 19, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-19 02:56:56.968127714 +0000 UTC m=+340583.224025104: ☑️ agreed by okJiang.
  • 2025-05-19 03:02:38.695340707 +0000 UTC m=+340924.951238100: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 0575ced into tikv:master May 19, 2025
24 of 25 checks passed
@JmPotato JmPotato deleted the keyspace_rg branch May 19, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved component/keyspace Key space. component/resource-control dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants