Skip to content

feat(resourcemanager): implement keyspace manager for resource groups #9331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 9 commits into from
May 21, 2025
Merged

feat(resourcemanager): implement keyspace manager for resource groups #9331

ti-chi-bot merged 9 commits into from
May 21, 2025

Conversation

@JmPotato
Copy link
Member

@JmPotato JmPotato commented May 19, 2025

What problem does this PR solve?

Issue Number: ref #9296.

What is changed and how does it work?

Add keyspace-level resource group management.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato requested review from lhy1024, okJiang and rleungx May 19, 2025 08:24
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 19, 2025
JmPotato
JmPotato commented May 19, 2025
View reviewed changes
JmPotato added 2 commits May 19, 2025 16:59
@JmPotato
test: fix TestBasicResourceGroupCURD
5c2f38a 
Signed-off-by: JmPotato <github@ipotato.me>
@JmPotato
fix: eliminate the deadlock
56b69bb 
Signed-off-by: JmPotato <github@ipotato.me>
@JmPotato JmPotato mentioned this pull request May 19, 2025
Open
6 tasks
@JmPotato
feat(resourcemanager): initialize reserved keyspace resource groups
d0118b2 
Signed-off-by: JmPotato <github@ipotato.me>
@codecov
Copy link

codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.61905% with 92 lines in your changes missing coverage. Please review.

Project coverage is 75.93%. Comparing base (04f1ae0) to head (08123e6).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9331      +/-   ##
==========================================
- Coverage   75.98%   75.93%   -0.05%     
==========================================
  Files         473      474       +1     
  Lines       73625    73819     +194     
==========================================
+ Hits        55945    56057     +112     
- Misses      14181    14239      +58     
- Partials     3499     3523      +24
Flag Coverage Δ
unittests 75.93% <72.61%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lhy1024
lhy1024 reviewed May 20, 2025
View reviewed changes
@JmPotato
chore: address the comments
8d84614 
Signed-off-by: JmPotato <github@ipotato.me>
@JmPotato JmPotato requested a review from lhy1024 May 20, 2025 02:51
lhy1024
lhy1024 reviewed May 20, 2025
View reviewed changes
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

@JmPotato
chore: remove getMutableResourceGroups
16d964c 
Signed-off-by: JmPotato <github@ipotato.me>
@JmPotato JmPotato requested a review from lhy1024 May 20, 2025 04:57
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 20, 2025
glorv
glorv reviewed May 20, 2025
View reviewed changes
rleungx
rleungx reviewed May 20, 2025
View reviewed changes
@JmPotato
feat(resourcemanager): use a unified background metrics flusher
7ac58b7 
Signed-off-by: JmPotato <github@ipotato.me>
@JmPotato JmPotato requested review from glorv and rleungx May 20, 2025 07:49
@JmPotato
test: refactor keyspace manager tests
8e78643 
Signed-off-by: JmPotato <github@ipotato.me>
@ti-chi-bot ti-chi-bot bot added the lgtm label May 21, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 21, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-20 06:05:33.784960106 +0000 UTC m=+68970.886127356: ☑️ agreed by lhy1024.
  • 2025-05-21 02:28:21.872008855 +0000 UTC m=+142338.973176076: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit fa84398 into tikv:master May 21, 2025
23 of 25 checks passed
@JmPotato JmPotato deleted the keyspace_rg_mgr branch May 21, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@rleungx rleungx rleungx approved these changes

@okJiang okJiang Awaiting requested review from okJiang

@glorv glorv Awaiting requested review from glorv

Assignees

No one assigned

Labels

approved component/keyspace Key space. component/resource-control dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JmPotato @glorv @lhy1024 @rleungx