mcs: suppport keyspace name in resource group api #9371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9371 +/- ##
==========================================
- Coverage 76.13% 76.12% -0.02%
==========================================
Files 477 478 +1
Lines 74282 74498 +216
==========================================
+ Hits 56557 56710 +153
- Misses 14211 14263 +52
- Partials 3514 3525 +11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JmPotato
reviewed
May 30, 2025
| // @Failure 404 {string} error | ||
| // @Param name path string true "groupName" | ||
| // @Param with_stats query bool false "whether to return statistics data." | ||
| // @Param keyspace_id query uint32 false "keyspace ID, if not set, it will be treated as null keyspace ID." |
Member
There was a problem hiding this comment.
Since the API is intended for external use rather than internal, we should use the keyspace name as the parameter. You might want to wait until #9354 is merged.
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
lhy1024
changed the title
Signed-off-by: lhy1024 <admin@liudos.us>
JmPotato
reviewed
Jun 5, 2025
| re.Equal(groupToUpdate.RUSettings.RU.Settings.FillRate, group.RUSettings.RU.Settings.FillRate) | ||
| } | ||
| // Delete the resource group. | ||
| suite.mustDeleteResourceGroup(re, groupToAdd.Name, keyspaceName) |
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
JmPotato
approved these changes
Jun 5, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
okJiang
approved these changes
Jun 5, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9296.
What is changed and how does it work?
Check List
Tests
Release note