Skip to content

Conversation

@JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #9296.

What is changed and how does it work?

Implement persistence for service limits in the resource manager. Service limits are now saved to storage when set and automatically loaded during initialization.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato requested review from lhy1024 and rleungx June 17, 2025 07:16
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 17, 2025
@JmPotato JmPotato force-pushed the persist_service_limit branch 3 times, most recently from 89506a6 to 8978f61 Compare June 18, 2025 02:55
Signed-off-by: JmPotato <github@ipotato.me>
@JmPotato JmPotato force-pushed the persist_service_limit branch from 8978f61 to 5c646e5 Compare June 18, 2025 06:29
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 18, 2025
Signed-off-by: JmPotato <github@ipotato.me>
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 18, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 18, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-18 07:11:07.980350918 +0000 UTC m=+255720.703529900: ☑️ agreed by lhy1024.
  • 2025-06-18 08:04:01.271686302 +0000 UTC m=+258893.994865284: ☑️ agreed by rleungx.

@JmPotato
Copy link
Member Author

/retest

Signed-off-by: JmPotato <github@ipotato.me>
@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 56.81818% with 19 lines in your changes missing coverage. Please review.

Project coverage is 76.18%. Comparing base (49c177a) to head (3c22f15).
Report is 3 commits behind head on master.

❌ Your patch status has failed because the patch coverage (56.81%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9413      +/-   ##
==========================================
- Coverage   76.18%   76.18%   -0.01%     
==========================================
  Files         478      478              
  Lines       74794    74840      +46     
==========================================
+ Hits        56984    57019      +35     
- Misses      14282    14297      +15     
+ Partials     3528     3524       -4     
Flag Coverage Δ
unittests 76.18% <56.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot merged commit 971fc9a into tikv:master Jun 18, 2025
25 of 27 checks passed
@JmPotato JmPotato deleted the persist_service_limit branch June 18, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved component/resource-control dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants