ctl: support to query the members and primary by using pdctl #9564

bufferflies · 2025-07-17T09:40:31Z

What problem does this PR solve?

Issue Number: Close #9567

What is changed and how does it work?

Check List

Tests

Unit test
Integration test

Code changes

Side effects

Related changes

Release note

None.

Signed-off-by: 童剑 <1045931706@qq.com>

ti-chi-bot · 2025-07-17T09:40:34Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: 童剑 <1045931706@qq.com>

rleungx · 2025-07-21T02:40:56Z

tools/pd-ctl/pdctl/command/scheduler_command.go

 	return c
 }

+// NewMicroServiceCommand returns a micro-service command.


Shall we put them into member command?

There is one command(member leader). I'm afraid the command is so similar to the mcs. Or do you think what's better command to show the mcs membership?

Then, how about adding a new subcommand in the root command?

Signed-off-by: 童剑 <1045931706@qq.com>

lhy1024

the rest LGTM

tools/pd-ctl/tests/scheduler/scheduler_test.go

okJiang

This is a feature request. Do you have a spec to explain the demand?

Signed-off-by: 童剑 <1045931706@qq.com>

bufferflies · 2025-07-23T07:49:02Z

This is a feature request. Do you have a spec to explain the demand?

Not the feature request, it's only for the debug

Signed-off-by: 童剑 <1045931706@qq.com>

bufferflies · 2025-07-30T06:45:27Z

/ping @rleungx

bufferflies · 2025-07-30T08:14:15Z

/ping @rleungx

rleungx · 2025-07-30T09:40:30Z

tools/pd-ctl/pdctl/ctl.go

 		command.NewKeyspaceGroupCommand(),
 		command.NewKeyspaceCommand(),
 		command.NewResourceManagerCommand(),
+		command.NewMsCommand(),


How about NewMicroServicesCommand or NewServicesCommand?

rleungx · 2025-07-30T09:51:54Z

tests/cluster.go

 }

+// GetTsoDefaultSpacePrimaryServer returns the primary TSO server for the default keyspace and keyspace group.
+func (c *TestCluster) GetTsoDefaultSpacePrimaryServer() *tso.Server {


Suggested change

func (c *TestCluster) GetTsoDefaultSpacePrimaryServer() *tso.Server {

func (c *TestCluster) GetDefaultTSOPrimaryServer() *tso.Server {

rleungx · 2025-07-30T09:52:42Z

tests/cluster.go

 }

+// SetTsoCluster sets the TSO cluster.
+func (c *TestCluster) SetTsoCluster(cluster *TestTSOCluster) {


Suggested change

func (c *TestCluster) SetTsoCluster(cluster *TestTSOCluster) {

func (c *TestCluster) SetTSOCluster(cluster *TestTSOCluster) {

Signed-off-by: 童剑 <1045931706@qq.com>

tools/pd-ctl/pdctl/command/microservice_command.go

rleungx

The rest LGTM

Signed-off-by: 童剑 <1045931706@qq.com>

ti-chi-bot · 2025-07-31T07:18:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [lhy1024,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-07-31T07:18:24Z

[LGTM Timeline notifier]

Timeline:

2025-07-30 07:00:38.020279654 +0000 UTC m=+74650.705549880: ☑️ agreed by lhy1024.
2025-07-31 07:18:22.477607407 +0000 UTC m=+162115.162877623: ☑️ agreed by rleungx.

Signed-off-by: 童剑 <1045931706@qq.com>

close tikv#9567 Signed-off-by: 童剑 <1045931706@qq.com> Signed-off-by: okjiang <819421878@qq.com>

ti-chi-bot · 2025-12-08T11:37:43Z

@bufferflies: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

Details

In response to adding label named type/cherry-pick-for-release-8.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close tikv#9567 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2025-12-08T11:38:18Z

In response to a cherrypick label: new pull request created to branch release-8.5: #10019.
But this PR has conflicts, please resolve them!

…10019) close #9567 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: 童剑 <1045931706@qq.com> Co-authored-by: tongjian <1045931706@qq.com> Co-authored-by: 童剑 <1045931706@qq.com>

bufferflies added 3 commits July 11, 2025 16:08

transfer

b455663

Signed-off-by: 童剑 <1045931706@qq.com>

add subcommand

14487f9

Signed-off-by: 童剑 <1045931706@qq.com>

mcs ctl

0221a79

Signed-off-by: 童剑 <1045931706@qq.com>

bufferflies marked this pull request as ready for review July 18, 2025 06:16

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2025

bufferflies requested review from okJiang and rleungx July 21, 2025 01:40

pass check

b91b43b

Signed-off-by: 童剑 <1045931706@qq.com>

rleungx reviewed Jul 21, 2025

View reviewed changes

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Jul 21, 2025

new root command

d927788

Signed-off-by: 童剑 <1045931706@qq.com>

bufferflies force-pushed the transfer_primary branch from dea58b8 to d927788 Compare July 22, 2025 07:59

rename

463ab8e

Signed-off-by: 童剑 <1045931706@qq.com>

bufferflies requested a review from lhy1024 July 22, 2025 10:04

lhy1024 reviewed Jul 23, 2025

View reviewed changes

tools/pd-ctl/tests/scheduler/scheduler_test.go Outdated Show resolved Hide resolved

okJiang reviewed Jul 23, 2025

View reviewed changes

Merge branch 'master' of github.com:tikv/pd into transfer_primary

15f8712

ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2025

new test for microservice

04ef3e3

Signed-off-by: 童剑 <1045931706@qq.com>

bufferflies force-pushed the transfer_primary branch from 5fc82c6 to 04ef3e3 Compare July 23, 2025 07:47

pass ut

d3660ae

Signed-off-by: 童剑 <1045931706@qq.com>

bufferflies requested a review from lhy1024 July 24, 2025 03:54

address comment

923685b

Signed-off-by: 童剑 <1045931706@qq.com>

lhy1024 approved these changes Jul 30, 2025

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 30, 2025

rleungx reviewed Jul 30, 2025

View reviewed changes

address comment

4ad9ffd

Signed-off-by: 童剑 <1045931706@qq.com>

rleungx reviewed Jul 31, 2025

View reviewed changes

tools/pd-ctl/pdctl/command/microservice_command.go Outdated Show resolved Hide resolved

rleungx reviewed Jul 31, 2025

View reviewed changes

address comment

db87666

Signed-off-by: 童剑 <1045931706@qq.com>

rleungx approved these changes Jul 31, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 31, 2025

bufferflies added 2 commits July 31, 2025 15:23

rename microservice

09cf0ac

Signed-off-by: 童剑 <1045931706@qq.com>

resolve conflict

ba1a69f

Signed-off-by: 童剑 <1045931706@qq.com>

ti-chi-bot bot merged commit d5d5a03 into tikv:master Jul 31, 2025
31 of 33 checks passed

okJiang pushed a commit to okJiang/pd that referenced this pull request Aug 7, 2025

ctl: support to query the members and primary by using pdctl (tikv#9564)

9ab5232

close tikv#9567 Signed-off-by: 童剑 <1045931706@qq.com> Signed-off-by: okjiang <819421878@qq.com>

bufferflies added type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Dec 8, 2025

ti-chi-bot bot removed the type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. label Dec 8, 2025

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 8, 2025

This is an automated cherry-pick of tikv#9564

f9757c8

close tikv#9567 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Dec 8, 2025

ctl: support to query the members and primary by using pdctl (#9564) #10019

Merged

	func (c TestCluster) GetTsoDefaultSpacePrimaryServer() tso.Server {
	func (c TestCluster) GetDefaultTSOPrimaryServer() tso.Server {

	func (c TestCluster) SetTsoCluster(cluster TestTSOCluster) {
	func (c TestCluster) SetTSOCluster(cluster TestTSOCluster) {

ctl: support to query the members and primary by using pdctl #9564

ctl: support to query the members and primary by using pdctl #9564

Uh oh!

Conversation

bufferflies commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

Uh oh!

ti-chi-bot bot commented Jul 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lhy1024 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

okJiang left a comment

Choose a reason for hiding this comment

Uh oh!

bufferflies commented Jul 23, 2025

Uh oh!

bufferflies commented Jul 30, 2025

Uh oh!

bufferflies commented Jul 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rleungx left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Jul 31, 2025

Uh oh!

ti-chi-bot bot commented Jul 31, 2025

[LGTM Timeline notifier]

Uh oh!

Uh oh!

ti-chi-bot bot commented Dec 8, 2025

Uh oh!

ti-chi-bot commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bufferflies commented Jul 17, 2025 •

edited

Loading