go: update Go version to 1.25.3 #9900

okJiang · 2025-11-03T09:39:40Z

What problem does this PR solve?

Issue Number: Close #10034

What is changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has the configuration change
Has HTTP API interfaces changed (Don't forget to add the declarative for the new API)
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tiup:
Need to cherry-pick to the release branch

Release note

None.

ti-chi-bot · 2025-11-03T09:39:43Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

okJiang · 2025-11-05T03:57:07Z

/retest

codecov · 2025-11-05T08:32:41Z

Codecov Report

❌ Patch coverage is 86.53846% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.41%. Comparing base (8c350af) to head (99060be).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9900      +/-   ##
==========================================
+ Coverage   78.32%   78.41%   +0.08%     
==========================================
  Files         511      511              
  Lines       68323    68415      +92     
==========================================
+ Hits        53514    53645     +131     
+ Misses      10923    10880      -43     
- Partials     3886     3890       +4

Flag	Coverage Δ
unittests	`78.41% <86.53%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

okJiang · 2025-11-05T08:57:13Z

/retest

okJiang · 2025-11-11T03:37:28Z

/retest

okJiang · 2025-11-11T03:40:53Z

/retest

purelind · 2025-12-10T05:04:09Z

/test ?

ti-chi-bot · 2025-12-10T05:04:13Z

@purelind: The following commands are available to trigger required jobs:

/test pull-build

/test pull-build-next-gen

/test pull-check-deps

/test pull-error-log-review

/test pull-integration-realcluster-test

/test pull-unit-test-next-gen-1

/test pull-unit-test-next-gen-2

/test pull-unit-test-next-gen-3

The following commands are available to trigger optional jobs:

/test pull-integration-copr-test

/test pull-integration-realcluster-test-next-gen

/test pull-unit-test

Use /test all to run the following jobs that were automatically triggered:

pull-build

pull-build-next-gen

pull-check-deps

pull-error-log-review

pull-unit-test-next-gen-1

pull-unit-test-next-gen-2

pull-unit-test-next-gen-3

tikv/pd/pull_integration_realcluster_test

tikv/pd/pull_integration_realcluster_test_next_gen

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

okJiang · 2025-12-10T07:03:25Z

/retest

wuhuizuo · 2025-12-10T07:21:00Z

/test pull-unit-test-next-gen-1 pull-unit-test-next-gen-2 pull-unit-test-next-gen-3

okJiang · 2025-12-10T08:31:58Z

/retest

okJiang · 2025-12-10T08:39:27Z

Makefile

 test-tso-function: install-tools
 	# testing TSO function...
 	@$(FAILPOINT_ENABLE)
-	CGO_ENABLED=1 go test -race -tags without_dashboard,deadlock $(TSO_FUNCTION_TEST_PKGS) || { $(FAILPOINT_DISABLE); exit 1; }


deadlock will be disable temporarily after upgrading golang1.25.

Track this in #10035

Upgrading deadlock is not useful?

I hadn't thought of this approach.😂

revert in 64cd23c

JmPotato · 2025-12-10T08:43:14Z

pkg/core/region_tree.go

+	if len(ranges) <= 1 {
+		if len(ranges) == 1 {


Reason for this change?

Then removing the line 400 would be more consistent.

done 1f63640

okJiang · 2025-12-10T08:55:30Z

/retest

rleungx · 2025-12-10T08:59:29Z

.golangci.yml

+        - deprecatedComment
+    govet:
+      disable:
+        - buildtag


Why disable it

I can't find a way to fix the warning in this code

//go:build !without_dashboard // +build !without_dashboard

If enable this lint

tests/dashboard/service_test.go:16:1: buildtag: +build line is no longer needed (govet) // +build !without_dashboard ^ 1 issues:

If remove // +build !without_dashboard, it will report another error. I don't find the error, let's try it in 061ae8d

Seems you have already removed it?

Yes, after removing, the ci is still normal.

okJiang · 2025-12-10T09:15:49Z

/retest

rleungx · 2025-12-10T09:21:03Z

.github/workflows/check.yaml

      - uses: actions/setup-go@v5
        with:
-          go-version: '1.23'
+          go-version: '1.25.5'


Shall we keep using '1.25'?

If using 1.25, the error will report https://github.com/tikv/pd/actions/runs/19253463340/job/55043026119

It could be caused by setup-go?

okJiang · 2025-12-10T09:39:31Z

/retest

okJiang · 2025-12-10T09:40:21Z

/retest

okJiang · 2025-12-10T09:54:31Z

/retest

Signed-off-by: okjiang <819421878@qq.com>

okJiang · 2025-12-11T03:48:27Z

/retest

Signed-off-by: okjiang <819421878@qq.com>

ti-chi-bot · 2025-12-11T04:20:57Z

@okJiang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-unit-test-next-gen	`b324e2a`	link	true	`/test pull-unit-test-next-gen`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Signed-off-by: okjiang <819421878@qq.com>

okJiang · 2025-12-11T05:16:44Z

/retest

okJiang · 2025-12-11T05:17:00Z

ping @rleungx @JmPotato

ti-chi-bot · 2025-12-11T05:23:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JmPotato,lhy1024]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-12-11T05:23:45Z

[LGTM Timeline notifier]

Timeline:

2025-12-10 09:12:45.722017635 +0000 UTC m=+1032310.535795207: ☑️ agreed by lhy1024.
2025-12-11 05:23:44.139225998 +0000 UTC m=+1104968.953003570: ☑️ agreed by JmPotato.

rleungx · 2025-12-11T06:02:29Z

.golangci.yml

+    # govet:
+    #   disable:
+    #     - buildtag


Why not remove it

close tikv#10034 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2025-12-12T02:34:38Z

In response to a cherrypick label: new pull request created to branch release-8.5: #10053.
But this PR has conflicts, please resolve them!

close #10034 Signed-off-by: okjiang <819421878@qq.com> Co-authored-by: okjiang <819421878@qq.com>

close tikv#10034 Signed-off-by: okjiang <819421878@qq.com> Co-authored-by: okjiang <819421878@qq.com> Signed-off-by: okjiang <819421878@qq.com>

close tikv#10034 Signed-off-by: okjiang <819421878@qq.com>

okJiang force-pushed the go-1.25 branch from e745db9 to 7df808d Compare November 5, 2025 08:24

okJiang marked this pull request as ready for review December 10, 2025 04:09

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2025

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Dec 10, 2025

okJiang commented Dec 10, 2025

View reviewed changes

JmPotato reviewed Dec 10, 2025

View reviewed changes

rleungx reviewed Dec 10, 2025

View reviewed changes

lhy1024 approved these changes Dec 10, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 10, 2025

ti-chi-bot bot added the approved label Dec 10, 2025

rleungx reviewed Dec 10, 2025

View reviewed changes

Merge master and revert deadlock

64cd23c

Signed-off-by: okjiang <819421878@qq.com>

okJiang force-pushed the go-1.25 branch from 8d6e2c1 to 64cd23c Compare December 11, 2025 03:24

okJiang added 2 commits December 11, 2025 12:11

fix comment

1f63640

Signed-off-by: okjiang <819421878@qq.com>

fix comment, upgrade setup-go to v6

b74b162

Signed-off-by: okjiang <819421878@qq.com>

fix setup-go

99060be

Signed-off-by: okjiang <819421878@qq.com>

JmPotato approved these changes Dec 11, 2025

View reviewed changes

ti-chi-bot bot added the lgtm label Dec 11, 2025

ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 11, 2025

ti-chi-bot bot merged commit 27c2705 into tikv:master Dec 11, 2025
39 of 42 checks passed

rleungx reviewed Dec 11, 2025

View reviewed changes

.golangci.yml

Comment on lines +57 to +59

# govet:

# disable:

# - buildtag

Copy link

Member

rleungx Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove it

ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 12, 2025

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 12, 2025

This is an automated cherry-pick of tikv#9900

16a0067

close tikv#10034 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Dec 12, 2025

go: update Go version to 1.25.5 (#9900) #10053

Merged

ti-chi-bot bot pushed a commit that referenced this pull request Dec 12, 2025

go: update Go version to 1.25.5 (#9900) (#10053)

26db5a6

close #10034 Signed-off-by: okjiang <819421878@qq.com> Co-authored-by: okjiang <819421878@qq.com>

okJiang added a commit to okJiang/pd that referenced this pull request Jan 30, 2026

go: update Go version to 1.25.5 (tikv#9900) (tikv#10053)

798b87f

close tikv#10034 Signed-off-by: okjiang <819421878@qq.com> Co-authored-by: okjiang <819421878@qq.com> Signed-off-by: okjiang <819421878@qq.com>

JmPotato pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 6, 2026

go: update Go version to 1.25.3 (tikv#9900)

40f3615

close tikv#10034 Signed-off-by: okjiang <819421878@qq.com>

go: update Go version to 1.25.3 #9900

go: update Go version to 1.25.3 #9900

Uh oh!

Conversation

okJiang commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

Uh oh!

ti-chi-bot bot commented Nov 3, 2025

Uh oh!

okJiang commented Nov 5, 2025

Uh oh!

codecov bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

okJiang commented Nov 5, 2025

Uh oh!

okJiang commented Nov 11, 2025

Uh oh!

okJiang commented Nov 11, 2025

Uh oh!

purelind commented Dec 10, 2025

Uh oh!

ti-chi-bot bot commented Dec 10, 2025

Uh oh!

okJiang commented Dec 10, 2025

Uh oh!

wuhuizuo commented Dec 10, 2025

Uh oh!

okJiang commented Dec 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rleungx Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

okJiang commented Dec 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

okJiang Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rleungx Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

okJiang commented Dec 10, 2025

Uh oh!

rleungx Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

okJiang Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

okJiang commented Dec 10, 2025

okJiang commented Nov 3, 2025 •

edited

Loading

codecov bot commented Nov 5, 2025 •

edited

Loading

rleungx Dec 10, 2025 •

edited

Loading

okJiang Dec 10, 2025 •

edited

Loading

rleungx Dec 10, 2025 •

edited

Loading

rleungx Dec 10, 2025 •

edited

Loading

okJiang Dec 10, 2025 •

edited

Loading

ti-chi-bot bot commented Dec 11, 2025 •

edited

Loading