Refactoring, speed improvements, optional dependencies #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blokhin Please, allow |
blokhin
reviewed
May 23, 2025
yascheduler.conf
Outdated
| engines_dir = %(data_dir)s/engines | ||
|
|
||
| [clouds] | ||
| hetzner_token = ngzcJHBUZ0MdbjrbrNaVOtDXmE8iXIpGvnTYVPx02wgHXsKxcbMCh2uhnGIbHj8X |
There was a problem hiding this comment.
@knopki I just discarded the token, no worries
blokhin
reviewed
May 23, 2025
yascheduler.conf
Outdated
There was a problem hiding this comment.
This file should not be committed, right?
There was a problem hiding this comment.
Yes, definitely. It's for testing only.
blokhin
reviewed
May 23, 2025
| @@ -50,7 +50,8 @@ def upcloud_create_node_sync( | |||
| user_data=cloud_config.render() if cloud_config else None, | |||
| ) | |||
| ) | |||
| ip_addr = server.get_public_ip() | |||
| ip_addr = cast(Optional[str], server.get_public_ip()) | |||
There was a problem hiding this comment.
wow, a modern Python becomes so complex!
There was a problem hiding this comment.
It's just a combination of a shitty library and my "I don't want to deal with UpCloud"
blokhin
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can be characterized as refactoring.
Most notable changes:
yascheduler[hetzner], but the current settings shouldn't break. See 1128c39 fix Lazy load or separate sub-packages for cloud providers #112Also:
ruff+pyrightinstead of big pile of toolssetuptoolshcloudversion to 2.xcollections.abcimports andDict->dict)