Binary flamegraph.pl may possibly overwrite official flamegraph.pl

[vovkasm]

Hi, we have an old bug in FreeBSD port of Devel::NYTProf module.

In short, both devel/p5-Devel-NYTProf and benchmarks/flamegraph ports try to install script flamegraph.pl into same place.

We can resolve this with renaming, but honestly I'd prefer to not patch original sources too extensively... Can we discuss a more general solution?
May be we can hide this script from users, or rename it to something like nytprof-flamegraph.pl, or maybe we can use upstream binary and depend on it?

Also let's mention author of flamegraph.pl, may be @brendangregg can help us with better solution?

[jkeenan]

In the CPAN distribution Devel-NYTProf, flamegraph.pl is currently located in the bin/ subdirectory. It's there presumably because that's where CPAN distros place their installable programs. But Devel-NYTProf is currently in "steady-state" mode. We're not adding new features; we fix some bugs; mainly we (I) try to keep its test suite PASSing against updated versions of the Perl core distribution. I think if we moved flamegraph.pl to the demo/ directory within the distribution, it would not get installed and hence there would be no conflict with your port of @brendangregg's version, which is probably better maintained than ours. How does that sound?

@timbunce ^^

[shawnlaffan]

flamegraph.pl is needed by nytprofhtml.pl.

devel-nytprof/bin/nytprofhtml

Lines 81 to 82 in 71b1fd5

	my $flamegraph = File::Spec->catfile($Config{'bin'}, 'flamegraph') . $script_ext;
	$flamegraph = which "flamegraph$script_ext" if not -e $flamegraph;

Perhaps it's better to rename the version in this repo to something like nyt_flamegraph.pl and update the calls as needed? Otherwise systems without their own flamegraph.pl will fail.

[timbunce]

Renaming seems fine to me.

[jkeenan]

Renaming seems fine to me.

Okay. For medical reasons, I'm going to be out of commission for a month or so. So if @shawnlaffan can prepare a pull request and @timbunce can apply it and do a CPAN release, that would be great. Otherwise, I'll have to defer action until early in 2025.

[vovkasm]

I can help with MR too, but not quickly either, maybe within one or two weeks

[shawnlaffan]

@jkeenan - Do you have time and capacity to merge the PR and cut a new release? (providing the PR looks good, of course).

New release of strawberry perl are "coming soon" and it would be nice to include an updated Devel::NYTProf flamegraph.

[jkeenan]

Please review #232. Thanks.