String match against $!

[eserte]

The line https://metacpan.org/dist/Devel-NYTProf/source/lib/Devel/NYTProf/Reader.pm#L138 currently reads

        confess "Unable to create directory $dir: $!\n" if $! !~ /exists/;

Using string matches against $! is problematic if the current process is running under a non-English locale (probably only the case for older perls). Better to use something like $!{EEXIST} or so.

I did not check the whole code, maybe there are more problematic places.

[jkeenan]

The line https://metacpan.org/dist/Devel-NYTProf/source/lib/Devel/NYTProf/Reader.pm#L138 currently reads

        confess "Unable to create directory $dir: $!\n" if $! !~ /exists/;

Using string matches against $! is problematic if the current process is running under a non-English locale (probably only the case for older perls). Better to use something like $!{EEXIST} or so.

I did not check the whole code, maybe there are more problematic places.

This entered the code base long before I had even heard of Devel-NYTProf:

commit b193a37f5ef7c638bddd3210d609439a8df3474d
Author:     Tim Bunce <Tim.Bunce@pobox.com>
AuthorDate: Sat Jul 26 17:28:11 2008 +0000
Commit:     Tim Bunce <Tim.Bunce@pobox.com>
CommitDate: Sat Jul 26 17:28:11 2008 +0000

    Run perltidy on the perl source code.
    

I'll take a look during my next round of maintenance on this module.